From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org, "Martin Ågren" <martin.agren@gmail.com>,
"brian m. carlson" <sandals@crustytoothpaste.net>
Subject: Re: [PATCH v2 1/1] t0001: fix on case-insensitive filesystems
Date: Mon, 24 Jun 2019 12:13:44 +0200 (CEST) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.1906241212220.44@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <xmqqh88ikfpb.fsf@gitster-ct.c.googlers.com>
Hi Junio,
On Fri, 21 Jun 2019, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > [Re-sending, as the Git mailing list seems to have decided to silently
> > drop this patch, I cannot see it on public-inbox.org, at least]
>
> Move that below the three-dash lines; otherwise the above two lines
> will make your in-body From: ineffective.
Indeed, sorry, I forgot.
> > diff --git a/t/t0001-init.sh b/t/t0001-init.sh
> > index 42a263cada..68f713884f 100755
> > --- a/t/t0001-init.sh
> > +++ b/t/t0001-init.sh
> > @@ -307,10 +307,22 @@ test_expect_success 'init prefers command line to GIT_DIR' '
> > test_path_is_missing otherdir/refs
> > '
> >
> > +downcase_on_case_insensitive_fs () {
> > + test true = "$(git config --get --type=bool core.ignorecase)" ||
> > + return 0
> > +
> > + for f
> > + do
> > + tr A-Z a-z <"$f" >"$f".downcased &&
> > + mv -f "$f".downcased "$f" || return 1
>
> It is easier to read to enclose the whole filename inside dq pair,
> i.e.
>
> tr A-Z a-z <"$f" >"$f.downcased" &&
> mv -f "$f.downcased" "$f" || return 1
Okay.
> Not grave enough to be worthy of a reroll on this one alone, though.
>
> > test_expect_success 'init with separate gitdir' '
> > rm -rf newdir &&
> > git init --separate-git-dir realgitdir newdir &&
> > echo "gitdir: $(pwd)/realgitdir" >expected &&
> > + downcase_on_case_insensitive_fs expected newdir/.git &&
>
> It is somewhat brittle to munge what is in "newdir/.git", which will
> affect later tests that use newdir/ as a repository (this one will
> be removed soon, but the last one in the sequence this patch touches
> will persist and is used by other tests). It's not like we are
> testing that Git will function OK even after futzing with the ".git"
> pointer file (if so, we'd want a separate test that specifically is
> designed to test that behaviour).
>
> I wonder if we want (possibly local) test_cmp_fspath that can be
> used more like
>
> test_cmp_fspath "$(pwd)/realgitdir" "$(sed -e "s/^gitdir: //" newdir/.git)"
>
> to compare two paths, honoring the case sensitivity of the
> filesystem.
I agree that that's a much better approach to fix the issue.
Thanks,
Dscho
>
> > test_cmp expected newdir/.git &&
> > test_path_is_dir realgitdir/refs
> > '
> > @@ -365,6 +377,7 @@ test_expect_success 're-init to update git link' '
> > git init --separate-git-dir ../surrealgitdir
> > ) &&
> > echo "gitdir: $(pwd)/surrealgitdir" >expected &&
> > + downcase_on_case_insensitive_fs expected newdir/.git &&
> > test_cmp expected newdir/.git &&
> > test_path_is_dir surrealgitdir/refs &&
> > test_path_is_missing realgitdir/refs
> > @@ -378,6 +391,7 @@ test_expect_success 're-init to move gitdir' '
> > git init --separate-git-dir ../realgitdir
> > ) &&
> > echo "gitdir: $(pwd)/realgitdir" >expected &&
> > + downcase_on_case_insensitive_fs expected newdir/.git &&
> > test_cmp expected newdir/.git &&
> > test_path_is_dir realgitdir/refs
> > '
> > --
> > gitgitgadget
>
next prev parent reply other threads:[~2019-06-24 10:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-08 14:43 [PATCH 0/1] Fix a test on NTFS (and probably HFS+) Johannes Schindelin via GitGitGadget
2019-06-08 14:43 ` [PATCH 1/1] t0001: fix on case-insensitive filesystems Johannes Schindelin via GitGitGadget
2019-06-09 19:23 ` Martin Ågren
2019-06-19 20:24 ` Johannes Schindelin
2019-06-09 20:13 ` brian m. carlson
2019-06-10 16:32 ` Junio C Hamano
2019-06-19 20:17 ` Johannes Schindelin
2019-06-21 19:33 ` Ævar Arnfjörð Bjarmason
[not found] ` <pull.151.v2.git.gitgitgadget@gmail.com>
[not found] ` <c2fdcf28e725c91a1a48c34226223866ad14bc0a.1560978437.git.gitgitgadget@gmail.com>
2019-06-21 14:34 ` [PATCH v2 " Johannes Schindelin
2019-06-21 17:31 ` Junio C Hamano
2019-06-24 10:13 ` Johannes Schindelin [this message]
2019-06-24 17:09 ` Junio C Hamano
2019-06-24 17:38 ` Johannes Schindelin
2019-06-24 19:22 ` Junio C Hamano
[not found] ` <pull.151.v3.git.gitgitgadget@gmail.com>
[not found] ` <1f0ceee8687e9032a7777f764b34b1c9ccc68f38.1561379363.git.gitgitgadget@gmail.com>
2019-06-24 17:40 ` [PATCH v3 " Johannes Schindelin
2019-06-24 18:55 ` Junio C Hamano
2019-06-25 10:50 ` vger vs GitGitGadget, was " Johannes Schindelin
2019-06-25 19:42 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.1906241212220.44@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=martin.agren@gmail.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).