From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH 1/1] t0001: fix on case-insensitive filesystems
Date: Mon, 10 Jun 2019 09:32:37 -0700 [thread overview]
Message-ID: <xmqqo935o0yi.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190609201302.GX8616@genre.crustytoothpaste.net> (brian m. carlson's message of "Sun, 9 Jun 2019 20:13:02 +0000")
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
>> test_expect_success 'init with separate gitdir' '
>> rm -rf newdir &&
>> git init --separate-git-dir realgitdir newdir &&
>> echo "gitdir: $(pwd)/realgitdir" >expected &&
>> + downcase_on_case_insensitive_fs expected newdir/.git &&
>
> I wonder if there's maybe a simpler way. If we canonicalize paths when
> writing them to the gitdir file, then writing "$(pwd -P)" on the line
> above should produce the right result.
>
> Now, technically, POSIX doesn't require case canonicalization of the
> path with "pwd -P", but then again, POSIX doesn't permit
> case-insensitive file systems, and we know the behavior on macOS uses
> bash, which does the right thing in this case because it calls
> realpath(3). I've tested that it also does the right thing on Linux when
> the worktree containing the Git checkout is in a path with symlinks.
>
> I don't know how that works on Windows, but if it does, it might be
> simpler.
Yup, it would be a worthwhile avenue to pursue; on the negative
side, a single-liner "no, unfortunately that would not work on
Windows" would also be useful.
Thanks.
next prev parent reply other threads:[~2019-06-10 16:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-08 14:43 [PATCH 0/1] Fix a test on NTFS (and probably HFS+) Johannes Schindelin via GitGitGadget
2019-06-08 14:43 ` [PATCH 1/1] t0001: fix on case-insensitive filesystems Johannes Schindelin via GitGitGadget
2019-06-09 19:23 ` Martin Ågren
2019-06-19 20:24 ` Johannes Schindelin
2019-06-09 20:13 ` brian m. carlson
2019-06-10 16:32 ` Junio C Hamano [this message]
2019-06-19 20:17 ` Johannes Schindelin
2019-06-21 19:33 ` Ævar Arnfjörð Bjarmason
[not found] ` <pull.151.v2.git.gitgitgadget@gmail.com>
[not found] ` <c2fdcf28e725c91a1a48c34226223866ad14bc0a.1560978437.git.gitgitgadget@gmail.com>
2019-06-21 14:34 ` [PATCH v2 " Johannes Schindelin
2019-06-21 17:31 ` Junio C Hamano
2019-06-24 10:13 ` Johannes Schindelin
2019-06-24 17:09 ` Junio C Hamano
2019-06-24 17:38 ` Johannes Schindelin
2019-06-24 19:22 ` Junio C Hamano
[not found] ` <pull.151.v3.git.gitgitgadget@gmail.com>
[not found] ` <1f0ceee8687e9032a7777f764b34b1c9ccc68f38.1561379363.git.gitgitgadget@gmail.com>
2019-06-24 17:40 ` [PATCH v3 " Johannes Schindelin
2019-06-24 18:55 ` Junio C Hamano
2019-06-25 10:50 ` vger vs GitGitGadget, was " Johannes Schindelin
2019-06-25 19:42 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo935o0yi.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=johannes.schindelin@gmx.de \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).