From: Junio C Hamano <gitster@pobox.com>
To: Derrick Stolee <derrickstolee@github.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
git@vger.kernel.org, "Glen Choo" <chooglen@google.com>,
"Jeff King" <peff@peff.net>
Subject: Re: [PATCH] CI: add SANITIZE=[address|undefined] jobs
Date: Wed, 27 Jul 2022 07:30:51 -0700 [thread overview]
Message-ID: <xmqqilnityp0.fsf@gitster.g> (raw)
In-Reply-To: d4dcb1f6-6076-3725-d479-7e9f1fece2a3@github.com
Derrick Stolee <derrickstolee@github.com> writes:
>> - jobname: linux-leaks
>> cc: gcc
>> pool: ubuntu-latest
>> + - jobname: SANITIZE=address
>> + cc: gcc
>> + pool: ubuntu-latest
>> + - jobname: SANITIZE=undefined
>> + cc: gcc
>> + pool: ubuntu-latest
>
>> @@ -277,6 +277,12 @@ linux-leaks)
>> export SANITIZE=leak
>> export GIT_TEST_PASSING_SANITIZE_LEAK=true
>> ;;
>> +SANITIZE=address)
>> + export SANITIZE=address
>> + ;;
>> +SANITIZE=undefined)
>> + export SANITIZE=undefined
>> + ;;
>
> In both of these cases, we are breaking from the nearby pattern. These
> jobs could be renamed to linux-address and linux-undefined to match the
> linux-leaks job.
>
> Alternatively, we could rename linux-leaks to SANITIZE=leak, since the
> point is not to test the Linux platform but to use the additional runtime
> checks (and Linux is the fasted CI platform).
I tend to agree that in the existing linux-leaks job, the
"linux"-ness is much less important than the "leaks"-ness, so the
"alternative" might be slightly more preferable, but I do not mind
the renaming goes the other way, either.
Thanks for your good eyes and good taste.
next prev parent reply other threads:[~2022-07-27 14:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 11:09 [PATCH] CI: add SANITIZE=[address|undefined] jobs Ævar Arnfjörð Bjarmason
2022-07-26 13:30 ` Derrick Stolee
2022-07-26 13:33 ` Ævar Arnfjörð Bjarmason
2022-07-27 11:34 ` Derrick Stolee
2022-07-27 14:30 ` Junio C Hamano [this message]
2022-07-28 16:52 ` Ævar Arnfjörð Bjarmason
2022-07-28 17:41 ` Junio C Hamano
2022-07-27 19:18 ` Jeff King
2022-07-28 16:54 ` Ævar Arnfjörð Bjarmason
2022-07-28 21:09 ` Jeff King
2022-07-28 21:31 ` Jeff King
2022-07-28 23:10 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqilnityp0.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=chooglen@google.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).