From: Derrick Stolee <derrickstolee@github.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>, git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
Glen Choo <chooglen@google.com>, Jeff King <peff@peff.net>
Subject: Re: [PATCH] CI: add SANITIZE=[address|undefined] jobs
Date: Tue, 26 Jul 2022 09:30:07 -0400 [thread overview]
Message-ID: <d4dcb1f6-6076-3725-d479-7e9f1fece2a3@github.com> (raw)
In-Reply-To: <patch-1.1-e48b6853dd5-20220726T110716Z-avarab@gmail.com>
On 7/26/2022 7:09 AM, Ævar Arnfjörð Bjarmason wrote:
> Add CI targets for SANITIZE=address and SANITIZE=undefined. The former
> would have caught a regression in 18bbc795fc5 (Merge branch
> 'gc/bare-repo-discovery', 2022-07-22) which made its way to
> "master"[1].
>
> Per [2] the GitHub fork of git.git runs with these in CI, so it's
> already useful to some forks of this repository.
I'm a fan of adding additional sanitizer checks in our CI. Let's let
computers do the work for us here instead of relying on humans.
> Also per [2] we could use SANITIZE=address with some ASAN_OPTIONS
> instead of our SANITIZE=leak job added in 956d2e4639b (tests: add a
> test mode for SANITIZE=leak, run it in CI, 2021-09-23), but unifying
> those two with these new jobs would be a lot harder, so let's leave
> that for now.
> - jobname: linux-leaks
> cc: gcc
> pool: ubuntu-latest
> + - jobname: SANITIZE=address
> + cc: gcc
> + pool: ubuntu-latest
> + - jobname: SANITIZE=undefined
> + cc: gcc
> + pool: ubuntu-latest
> @@ -277,6 +277,12 @@ linux-leaks)
> export SANITIZE=leak
> export GIT_TEST_PASSING_SANITIZE_LEAK=true
> ;;
> +SANITIZE=address)
> + export SANITIZE=address
> + ;;
> +SANITIZE=undefined)
> + export SANITIZE=undefined
> + ;;
In both of these cases, we are breaking from the nearby pattern. These
jobs could be renamed to linux-address and linux-undefined to match the
linux-leaks job.
Alternatively, we could rename linux-leaks to SANITIZE=leak, since the
point is not to test the Linux platform but to use the additional runtime
checks (and Linux is the fasted CI platform).
Thanks,
-Stolee
next prev parent reply other threads:[~2022-07-26 13:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 11:09 [PATCH] CI: add SANITIZE=[address|undefined] jobs Ævar Arnfjörð Bjarmason
2022-07-26 13:30 ` Derrick Stolee [this message]
2022-07-26 13:33 ` Ævar Arnfjörð Bjarmason
2022-07-27 11:34 ` Derrick Stolee
2022-07-27 14:30 ` Junio C Hamano
2022-07-28 16:52 ` Ævar Arnfjörð Bjarmason
2022-07-28 17:41 ` Junio C Hamano
2022-07-27 19:18 ` Jeff King
2022-07-28 16:54 ` Ævar Arnfjörð Bjarmason
2022-07-28 21:09 ` Jeff King
2022-07-28 21:31 ` Jeff King
2022-07-28 23:10 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4dcb1f6-6076-3725-d479-7e9f1fece2a3@github.com \
--to=derrickstolee@github.com \
--cc=avarab@gmail.com \
--cc=chooglen@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).