From: Jeff King <peff@peff.net>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Glen Choo <chooglen@google.com>
Subject: Re: [PATCH] CI: add SANITIZE=[address|undefined] jobs
Date: Thu, 28 Jul 2022 17:31:13 -0400 [thread overview]
Message-ID: <YuMAIfM3jv6lI9SA@coredump.intra.peff.net> (raw)
In-Reply-To: <YuL7EotrIpnOn5BT@coredump.intra.peff.net>
On Thu, Jul 28, 2022 at 05:09:38PM -0400, Jeff King wrote:
> > Ditto TEST_NO_MALLOC_CHECK=1 & --no-bin-wrappers, but we can think about
> > all of those some other time....
>
> I'd be surprised if the malloc checking itself is all that expensive,
> though it does look like we call getconf and expr once per test there
> for setup. We could almost certainly hoist that out and call it once per
> script.
Nope, I was totally wrong here. Running with TEST_NO_MALLOC_CHECK=1 does
indeed make a big difference:
Benchmark 1: make test
Time (mean ± σ): 67.486 s ± 3.339 s [User: 622.643 s, System: 409.951 s]
Range (min … max): 63.634 s … 69.550 s 3 runs
Benchmark 2: TEST_NO_MALLOC_CHECK=1 make test
Time (mean ± σ): 57.596 s ± 0.899 s [User: 577.273 s, System: 291.627 s]
Range (min … max): 57.072 s … 58.634 s 3 runs
Eliminating the extra per-test processes with the patch below helps a
little, but most of the effort really is (presumably) going to the
actual malloc checking code:
Benchmark 1: make test [nb: after applying patch...]
Time (mean ± σ): 67.091 s ± 0.385 s [User: 599.382 s, System: 410.781 s]
Range (min … max): 66.648 s … 67.343 s 3 runs
Curious that most of the CPU time seems to go into system time. I'd have
thought it was extra internal malloc debugging bits, but maybe it is
allocating mmap/brk calls in a less efficient way. I dunno how any of it
actually works.
-Peff
---
diff --git a/t/test-lib.sh b/t/test-lib.sh
index 55857af601..303fbe8ecc 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -557,14 +557,20 @@ then
: nothing
}
else
+ if _GLIBC_VERSION=$(getconf GNU_LIBC_VERSION 2>/dev/null) &&
+ _GLIBC_VERSION=${_GLIBC_VERSION#"glibc "} &&
+ expr 2.34 \<= "$_GLIBC_VERSION" >/dev/null
+ then
+ USE_LIBC_MALLOC_DEBUG=t
+ else
+ USE_LIBC_MALLOC_DEBUG=
+ fi
setup_malloc_check () {
local g
local t
MALLOC_CHECK_=3 MALLOC_PERTURB_=165
export MALLOC_CHECK_ MALLOC_PERTURB_
- if _GLIBC_VERSION=$(getconf GNU_LIBC_VERSION 2>/dev/null) &&
- _GLIBC_VERSION=${_GLIBC_VERSION#"glibc "} &&
- expr 2.34 \<= "$_GLIBC_VERSION" >/dev/null
+ if test -n "$USE_LIBC_MALLOC_DEBUG"
then
g=
LD_PRELOAD="libc_malloc_debug.so.0"
next prev parent reply other threads:[~2022-07-28 21:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 11:09 [PATCH] CI: add SANITIZE=[address|undefined] jobs Ævar Arnfjörð Bjarmason
2022-07-26 13:30 ` Derrick Stolee
2022-07-26 13:33 ` Ævar Arnfjörð Bjarmason
2022-07-27 11:34 ` Derrick Stolee
2022-07-27 14:30 ` Junio C Hamano
2022-07-28 16:52 ` Ævar Arnfjörð Bjarmason
2022-07-28 17:41 ` Junio C Hamano
2022-07-27 19:18 ` Jeff King
2022-07-28 16:54 ` Ævar Arnfjörð Bjarmason
2022-07-28 21:09 ` Jeff King
2022-07-28 21:31 ` Jeff King [this message]
2022-07-28 23:10 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuMAIfM3jv6lI9SA@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=chooglen@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).