From: Junio C Hamano <gitster@pobox.com>
To: Brandon Williams <bmwill@google.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH 1/2] ls-files: adding support for submodules
Date: Tue, 27 Sep 2016 15:23:02 -0700 [thread overview]
Message-ID: <xmqqh991kmnt.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160927220955.GA38615@google.com> (Brandon Williams's message of "Tue, 27 Sep 2016 15:09:55 -0700")
Brandon Williams <bmwill@google.com> writes:
>> If you are in a subdirectory of your superproject, say, a/,
>>
>> cd a && git ls-files --recurse-submodules -- "b*"
>>
>> I would expect we would recurse into the submodule at "a/b" and find
>> "b/file-at-top-of-B". What does the internal invocation to do so
>> would look like? I would think "git -C b --super=b ls-files" that
>> is run from "a".
Actually, the internal invocation may have to be
$ git --super=a/b ls-files -- "a/b*"
if the desired overall output needs to be in the "--full-name" mode.
That is, the top-level recursive one may be
cd a && git ls-files --recurse-submodules --full-name -- "b*"
This top-level "ls-files" will have "prefix" set to "a/". Because
it is run in the "--full-name" mode, after finding that the
submodule at "a/b" matches the given pathspec and deciding to
recurse into it, it needs to arrange that paths stored in the index
of the submodule are prefixed with "a/b/", not with "b/", when
shown.
prev parent reply other threads:[~2016-09-27 22:23 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 22:04 [PATCH 1/2] ls-files: adding support for submodules Brandon Williams
2016-09-21 22:04 ` [PATCH 2/2] ls-files: add pathspec matching " Brandon Williams
2016-09-21 22:53 ` Junio C Hamano
2016-09-21 23:23 ` Brandon Williams
2016-09-21 23:28 ` [PATCH 2/2 v2] " Brandon Williams
2016-09-23 18:48 ` Junio C Hamano
2016-09-23 19:20 ` Junio C Hamano
2016-09-23 20:49 ` Brandon Williams
2016-09-21 22:08 ` [PATCH 1/2] ls-files: adding support " Brandon Williams
2016-09-21 22:28 ` Junio C Hamano
2016-09-21 22:38 ` Brandon Williams
2016-09-21 22:42 ` [PATCH 1/2] ls-files: optionally recurse into submodules Brandon Williams
2016-09-22 6:20 ` Jeff King
2016-09-23 23:31 ` Brandon Williams
2016-09-21 23:13 ` [PATCH 1/2] ls-files: adding support for submodules Junio C Hamano
2016-09-22 4:18 ` Jeff King
2016-09-22 16:04 ` Stefan Beller
2016-09-22 18:13 ` Junio C Hamano
2016-09-23 3:41 ` Jeff King
2016-09-23 5:47 ` Stefan Beller
2016-09-23 6:06 ` Jeff King
2016-09-23 16:16 ` Brandon Williams
2016-09-23 16:34 ` Stefan Beller
2016-09-25 11:03 ` Nazri Ramliy
2016-09-27 21:38 ` Junio C Hamano
2016-09-27 21:48 ` Brandon Williams
2016-09-27 22:01 ` Junio C Hamano
2016-09-27 22:09 ` Brandon Williams
2016-09-27 22:23 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh991kmnt.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).