From: Stefan Beller <sbeller@google.com>
To: Brandon Williams <bmwill@google.com>
Cc: Jeff King <peff@peff.net>, Junio C Hamano <gitster@pobox.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] ls-files: adding support for submodules
Date: Fri, 23 Sep 2016 09:34:51 -0700 [thread overview]
Message-ID: <CAGZ79kYF6nYL42VQ_mbVzD+2QFLPELe9-8DOQjbSwArM20SCKA@mail.gmail.com> (raw)
In-Reply-To: <CAKoko1p+M3X_y+DH+65fUDRZjkiZrKE3Z-jjq=RSjqoi7He8pw@mail.gmail.com>
On Fri, Sep 23, 2016 at 9:16 AM, Brandon Williams <bmwill@google.com> wrote:
>> Yeah, a positive "I support this" flag would at least let us correctly
>> flag errors, which is the best we can do. That won't work for
>> non-builtins, but perhaps it is good enough in practice.
>>
>> -Peff
>
>
> So it sounds like we agree that this prefix option should be pushed to
> the top level.
> The question is have we come to a consensus on what we should be
> calling the option?
The option itself is very similar to -C, which changes the directory to the
given argument before executing the git command.
e.g. in git:
git -C builtin ls-files
add.c
...
So for the submodule case we'd want that plus keeping around that prefix,
which makes me wonder if we could just store the argument of -C into a global
and use that when --keep-prefix is given, so you'd do a
git -C path/to/sub --keep-prefix ls-files
path/to/sub/file1
...
maybe --[keep|use]-[path|prefix] ?
You could of course go with a fully independent option, but how
would that work together with -C ?
(first change the dir and then change again while remembering the prefix?
or the other way round?)
> Leave it as submodule-prefix or do we need to come up with a different name?
>
> -Brandon
next prev parent reply other threads:[~2016-09-23 16:34 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 22:04 [PATCH 1/2] ls-files: adding support for submodules Brandon Williams
2016-09-21 22:04 ` [PATCH 2/2] ls-files: add pathspec matching " Brandon Williams
2016-09-21 22:53 ` Junio C Hamano
2016-09-21 23:23 ` Brandon Williams
2016-09-21 23:28 ` [PATCH 2/2 v2] " Brandon Williams
2016-09-23 18:48 ` Junio C Hamano
2016-09-23 19:20 ` Junio C Hamano
2016-09-23 20:49 ` Brandon Williams
2016-09-21 22:08 ` [PATCH 1/2] ls-files: adding support " Brandon Williams
2016-09-21 22:28 ` Junio C Hamano
2016-09-21 22:38 ` Brandon Williams
2016-09-21 22:42 ` [PATCH 1/2] ls-files: optionally recurse into submodules Brandon Williams
2016-09-22 6:20 ` Jeff King
2016-09-23 23:31 ` Brandon Williams
2016-09-21 23:13 ` [PATCH 1/2] ls-files: adding support for submodules Junio C Hamano
2016-09-22 4:18 ` Jeff King
2016-09-22 16:04 ` Stefan Beller
2016-09-22 18:13 ` Junio C Hamano
2016-09-23 3:41 ` Jeff King
2016-09-23 5:47 ` Stefan Beller
2016-09-23 6:06 ` Jeff King
2016-09-23 16:16 ` Brandon Williams
2016-09-23 16:34 ` Stefan Beller [this message]
2016-09-25 11:03 ` Nazri Ramliy
2016-09-27 21:38 ` Junio C Hamano
2016-09-27 21:48 ` Brandon Williams
2016-09-27 22:01 ` Junio C Hamano
2016-09-27 22:09 ` Brandon Williams
2016-09-27 22:23 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGZ79kYF6nYL42VQ_mbVzD+2QFLPELe9-8DOQjbSwArM20SCKA@mail.gmail.com \
--to=sbeller@google.com \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).