From: Jeff King <peff@peff.net>
To: Stefan Beller <sbeller@google.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Brandon Williams <bmwill@google.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH 1/2] ls-files: adding support for submodules
Date: Fri, 23 Sep 2016 02:06:43 -0400 [thread overview]
Message-ID: <20160923060643.3ubr5gn7qczzs2ut@sigill.intra.peff.net> (raw)
In-Reply-To: <CAGZ79kZ+LTd5PuT4+Z9K6d+GQ-33E=tLY1Fokbp22uNoygaEtg@mail.gmail.com>
On Thu, Sep 22, 2016 at 10:47:17PM -0700, Stefan Beller wrote:
> On Thu, Sep 22, 2016 at 8:41 PM, Jeff King <peff@peff.net> wrote:
>
> >> * As Stefan alluded to (much) earlier, it might be a better idea
> >> to have these 'prefix' as the global option to "git" potty, not
> >> to each subcommand that happens to support them;
> >
> > That seems like it would be nice, but there's going to be an interim
> > period where some commands do not respect the global "--prefix" at all
> > (in the worst case, consider a third party command).
>
> My current line of thinking is to have a new flag in command struct in
> git.c to enable the global --prefix, (c.f. RUN_SETUP | NEED_WORK_TREE)
> so we'd have a ALLOW_OUTSIDE_PREFIX flag which can be used to enable
> this feature. In case that flag is not set, but a user tries a
> --prefix=<somewhere>
> we can still
>
> die("nope, we don't do that");
Yeah, a positive "I support this" flag would at least let us correctly
flag errors, which is the best we can do. That won't work for
non-builtins, but perhaps it is good enough in practice.
-Peff
next prev parent reply other threads:[~2016-09-23 6:06 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 22:04 [PATCH 1/2] ls-files: adding support for submodules Brandon Williams
2016-09-21 22:04 ` [PATCH 2/2] ls-files: add pathspec matching " Brandon Williams
2016-09-21 22:53 ` Junio C Hamano
2016-09-21 23:23 ` Brandon Williams
2016-09-21 23:28 ` [PATCH 2/2 v2] " Brandon Williams
2016-09-23 18:48 ` Junio C Hamano
2016-09-23 19:20 ` Junio C Hamano
2016-09-23 20:49 ` Brandon Williams
2016-09-21 22:08 ` [PATCH 1/2] ls-files: adding support " Brandon Williams
2016-09-21 22:28 ` Junio C Hamano
2016-09-21 22:38 ` Brandon Williams
2016-09-21 22:42 ` [PATCH 1/2] ls-files: optionally recurse into submodules Brandon Williams
2016-09-22 6:20 ` Jeff King
2016-09-23 23:31 ` Brandon Williams
2016-09-21 23:13 ` [PATCH 1/2] ls-files: adding support for submodules Junio C Hamano
2016-09-22 4:18 ` Jeff King
2016-09-22 16:04 ` Stefan Beller
2016-09-22 18:13 ` Junio C Hamano
2016-09-23 3:41 ` Jeff King
2016-09-23 5:47 ` Stefan Beller
2016-09-23 6:06 ` Jeff King [this message]
2016-09-23 16:16 ` Brandon Williams
2016-09-23 16:34 ` Stefan Beller
2016-09-25 11:03 ` Nazri Ramliy
2016-09-27 21:38 ` Junio C Hamano
2016-09-27 21:48 ` Brandon Williams
2016-09-27 22:01 ` Junio C Hamano
2016-09-27 22:09 ` Brandon Williams
2016-09-27 22:23 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160923060643.3ubr5gn7qczzs2ut@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).