From: Junio C Hamano <gitster@pobox.com>
To: 林自均 <johnlinp@gmail.com>
Cc: Git <git@vger.kernel.org>,
"brian m. carlson" <sandals@crustytoothpaste.net>,
phillip.wood@dunelm.org.uk
Subject: Re: [PATCH v2] status: add an empty line when there is no hint
Date: Mon, 13 May 2019 14:51:37 +0900 [thread overview]
Message-ID: <xmqqh89ydhqu.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CAKO26Mtn+KDnkHWsKf8mAyTmeaCYK0gjdNad5bxJe-qxjKs=xw@mail.gmail.com> ("林自均"'s message of "Fri, 10 May 2019 08:56:00 +0800")
林自均 <johnlinp@gmail.com> writes:
> Hi Junio,
>> ...
> Could you please give me some advice on my patch? Thank you.
I tend to agree with what Phillip said in
<ae1332b8-a227-e83a-8862-8811b6a81251@gmail.com>.
If the difference between "status" and "commit" bothers you so much,
i.e.
When typing "git status", there is an empty line between the
"Changes not staged for commit:" block and the list of changed
files. However, when typing "git commit" with no files added,
there are no empty lines between them.
it may not be a bad idea to try making them consistent by removing
the blank line that is given after the advice messages, perhaps?
next prev parent reply other threads:[~2019-05-13 5:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 6:02 [PATCH v2] status: add an empty line when there is no hint John Lin
2019-04-30 11:15 ` Phillip Wood
2019-04-30 22:23 ` 林自均
2019-05-01 23:45 ` brian m. carlson
2019-05-02 0:35 ` 林自均
2019-05-02 23:15 ` brian m. carlson
2019-05-03 4:15 ` 林自均
2019-05-10 0:56 ` 林自均
2019-05-13 5:51 ` Junio C Hamano [this message]
2019-05-14 0:30 ` 林自均
2019-05-14 2:04 ` brian m. carlson
2019-05-14 7:33 ` Junio C Hamano
2019-05-14 9:43 ` 林自均
2019-05-15 0:48 ` Junio C Hamano
2019-05-15 3:02 ` 林自均
2019-05-22 23:01 ` 林自均
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh89ydhqu.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=johnlinp@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).