From: 林自均 <johnlinp@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>,
Git <git@vger.kernel.org>,
phillip.wood@dunelm.org.uk
Subject: Re: [PATCH v2] status: add an empty line when there is no hint
Date: Wed, 15 May 2019 11:02:59 +0800 [thread overview]
Message-ID: <CAKO26MvNJ6q-GPvY8QSrc+9-HYKK=rBJuNUrMK8EgC9YEq2O5Q@mail.gmail.com> (raw)
In-Reply-To: <xmqq4l5wa6fm.fsf@gitster-ct.c.googlers.com>
Hi Junio,
Junio C Hamano <gitster@pobox.com> 於 2019年5月15日 週三 上午8:48寫道:
>
> 林自均 <johnlinp@gmail.com> writes:
>
> > I was not talking about the messages in the editor session. I was
> > talking about "git commit" without "git add" anything.
> >
> > For example:
> >
> > ```
> > $ touch newfile.txt
> > $ git commit
> > On branch master
> > Untracked files:
> > newfile.txt
> >
> > nothing added to commit but untracked files present
> > ```
> >
> > My current patch is trying to add an empty line between
> > "Untracked files:" and "newfile.txt".
>
> I do not think that one is paged, so if you ask me, I'd say we
> shouldn't add an extra blank there. Is that message also reused in
> the editor session, or do two different codepaths produce a similar
> looking message, one for the above case direct to the terminal and
> the other for the editor session?
The messages produced in wt-status.c seem to be reused in
both terminal and editor session. When I tried to modify the
messages in terminal, the ones in editor session will also
be modified accordingly.
By the way, my new patch to remove extra blank line is here:
https://github.com/gitgitgadget/git/pull/196
I am still waiting for someone to comment "/allow johnlinp".
>
> But again...
>
> >> At the same time, I think I've been happy enough with the current
> >> output from both commands, so if you let me bikeshed freely, I'd
> >> probably pick "let's not change anything then" ;-)
>
next prev parent reply other threads:[~2019-05-15 3:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 6:02 [PATCH v2] status: add an empty line when there is no hint John Lin
2019-04-30 11:15 ` Phillip Wood
2019-04-30 22:23 ` 林自均
2019-05-01 23:45 ` brian m. carlson
2019-05-02 0:35 ` 林自均
2019-05-02 23:15 ` brian m. carlson
2019-05-03 4:15 ` 林自均
2019-05-10 0:56 ` 林自均
2019-05-13 5:51 ` Junio C Hamano
2019-05-14 0:30 ` 林自均
2019-05-14 2:04 ` brian m. carlson
2019-05-14 7:33 ` Junio C Hamano
2019-05-14 9:43 ` 林自均
2019-05-15 0:48 ` Junio C Hamano
2019-05-15 3:02 ` 林自均 [this message]
2019-05-22 23:01 ` 林自均
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKO26MvNJ6q-GPvY8QSrc+9-HYKK=rBJuNUrMK8EgC9YEq2O5Q@mail.gmail.com' \
--to=johnlinp@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=phillip.wood@dunelm.org.uk \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).