From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: 林自均 <johnlinp@gmail.com>
Cc: phillip.wood@dunelm.org.uk, Git <git@vger.kernel.org>
Subject: Re: [PATCH v2] status: add an empty line when there is no hint
Date: Thu, 2 May 2019 23:15:37 +0000 [thread overview]
Message-ID: <20190502231537.GE202237@genre.crustytoothpaste.net> (raw)
In-Reply-To: <CAKO26MvXmOMHgqWSoVrmdwyDFyqDrChkMOHq6iuJAX8pvHzZoA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 422 bytes --]
On Thu, May 02, 2019 at 08:35:23AM +0800, 林自均 wrote:
> Thank you for the support! I'll be very happy if my patch can get into
> the code base. Is there any improvement I can make for this patch?
The patch seems sane to me. There's less duplicate code than the patch I
started writing; the goto conclude seems to avoid most of it.
--
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 868 bytes --]
next prev parent reply other threads:[~2019-05-02 23:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 6:02 [PATCH v2] status: add an empty line when there is no hint John Lin
2019-04-30 11:15 ` Phillip Wood
2019-04-30 22:23 ` 林自均
2019-05-01 23:45 ` brian m. carlson
2019-05-02 0:35 ` 林自均
2019-05-02 23:15 ` brian m. carlson [this message]
2019-05-03 4:15 ` 林自均
2019-05-10 0:56 ` 林自均
2019-05-13 5:51 ` Junio C Hamano
2019-05-14 0:30 ` 林自均
2019-05-14 2:04 ` brian m. carlson
2019-05-14 7:33 ` Junio C Hamano
2019-05-14 9:43 ` 林自均
2019-05-15 0:48 ` Junio C Hamano
2019-05-15 3:02 ` 林自均
2019-05-22 23:01 ` 林自均
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190502231537.GE202237@genre.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=git@vger.kernel.org \
--cc=johnlinp@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).