From: Junio C Hamano <gitster@pobox.com>
To: Brandon Williams <bmwill@google.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] ls-files: adding support for submodules
Date: Thu, 15 Sep 2016 13:57:45 -0700 [thread overview]
Message-ID: <xmqqeg4knanq.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <xmqqzinbvk15.fsf@gitster.mtv.corp.google.com> (Junio C. Hamano's message of "Tue, 13 Sep 2016 09:31:18 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> Thanks, will queue with a minimum fix.
So here are two squashable patches, one is the "minimum" one, the
other is a bit more invasive one to use "a pointer to an optional
setting is set to NULL" convention. I am undecided, and I'll stay
to be without further comments from others, on the latter one.
I understand that many internal changes in your work environment are
titled like "DOing X", but our convention around here is to label
them "DO X", as if you are giving an order to somebody else, either
telling the codebase "to be like so", or telling the patch-monkey
maintainer "to make it so". So I'd retitle it
ls-files: optionally recurse into submodules
or something like that. It is an added advantage of being a lot
more descriptive than "adding support", which does not say what kind
of support it is adding.
next prev parent reply other threads:[~2016-09-15 20:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 21:53 [RFC/PATCH] ls-files: adding support for submodules Brandon Williams
2016-09-09 22:35 ` Jeff King
2016-09-09 22:40 ` Junio C Hamano
2016-09-09 23:01 ` Junio C Hamano
2016-09-09 23:47 ` Stefan Beller
2016-09-11 22:10 ` Junio C Hamano
2016-09-12 0:51 ` Jeff King
2016-09-12 0:52 ` Jeff King
2016-09-12 16:01 ` Junio C Hamano
[not found] ` <CAKoko1oSEac_Nr1SkRB=dM_r3Jnew1Et2ZKj716iU3JLyHe2GQ@mail.gmail.com>
2016-09-12 17:39 ` Brandon Williams
2016-09-12 1:47 ` Junio C Hamano
2016-09-13 0:33 ` [PATCH v2] " Brandon Williams
2016-09-13 3:35 ` Brandon Williams
2016-09-13 16:31 ` Junio C Hamano
2016-09-15 20:51 ` Junio C Hamano
2016-09-15 20:51 ` [PATCH 1/2] SQUASH??? Junio C Hamano
2016-09-15 20:51 ` [PATCH 2/2] SQUASH??? Undecided Junio C Hamano
2016-09-15 21:12 ` Stefan Beller
2016-09-15 21:37 ` Brandon Williams
2016-09-15 20:57 ` Junio C Hamano [this message]
2016-09-15 20:58 ` [PATCH v2] ls-files: adding support for submodules Junio C Hamano
2016-09-15 20:58 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqeg4knanq.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).