From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Stefan Beller <sbeller@google.com>,
Brandon Williams <bmwill@google.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [RFC/PATCH] ls-files: adding support for submodules
Date: Sun, 11 Sep 2016 20:52:30 -0400 [thread overview]
Message-ID: <20160912005229.6njhgfq7h6cb34s4@sigill.intra.peff.net> (raw)
In-Reply-To: <20160912005106.fj7adhmtfklv4vir@sigill.intra.peff.net>
On Sun, Sep 11, 2016 at 08:51:06PM -0400, Jeff King wrote:
> On Sun, Sep 11, 2016 at 03:10:13PM -0700, Junio C Hamano wrote:
>
> > So a "ls-files" that is done internally in the end-user facing "git
> > grep --recurse-submodules" needs to be run _without_ recursing
> > itself at least once to learn "lib/" is a submodule. A flat "here
> > are everything we have" does not sound like a good building block.
>
> I do not use submodules myself, but I could imagine that you may have
> scripts outside of git that do not care about the submodule divisions at
> all, and would be happy with the flat block. E.g., our "make tags"
> target uses "git ls-files" so find all of the source files. I could
> imagine projects with submodules that would want to do so recursively (I
> could also imagine projects that do _not_ want to do so; it would depend
> on your workflow and how tightly bound the submodules are). Another
> plausible example would be something grep-like that has features
> git-grep does not (I don't use "ack", but perhaps "git ls-files
> --recurse-submodules -z | xargs --null ack ..." is something people
> would want to do).
None of that negates your point, btw, which is that this does not seem
like a great building block for "git grep --recurse-submodules". Just
that it seems plausible to me that people could find recursive
"ls-files" useful on its own.
-Peff
next prev parent reply other threads:[~2016-09-12 0:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 21:53 [RFC/PATCH] ls-files: adding support for submodules Brandon Williams
2016-09-09 22:35 ` Jeff King
2016-09-09 22:40 ` Junio C Hamano
2016-09-09 23:01 ` Junio C Hamano
2016-09-09 23:47 ` Stefan Beller
2016-09-11 22:10 ` Junio C Hamano
2016-09-12 0:51 ` Jeff King
2016-09-12 0:52 ` Jeff King [this message]
2016-09-12 16:01 ` Junio C Hamano
[not found] ` <CAKoko1oSEac_Nr1SkRB=dM_r3Jnew1Et2ZKj716iU3JLyHe2GQ@mail.gmail.com>
2016-09-12 17:39 ` Brandon Williams
2016-09-12 1:47 ` Junio C Hamano
2016-09-13 0:33 ` [PATCH v2] " Brandon Williams
2016-09-13 3:35 ` Brandon Williams
2016-09-13 16:31 ` Junio C Hamano
2016-09-15 20:51 ` Junio C Hamano
2016-09-15 20:51 ` [PATCH 1/2] SQUASH??? Junio C Hamano
2016-09-15 20:51 ` [PATCH 2/2] SQUASH??? Undecided Junio C Hamano
2016-09-15 21:12 ` Stefan Beller
2016-09-15 21:37 ` Brandon Williams
2016-09-15 20:57 ` [PATCH v2] ls-files: adding support for submodules Junio C Hamano
2016-09-15 20:58 ` Junio C Hamano
2016-09-15 20:58 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160912005229.6njhgfq7h6cb34s4@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).