From: Stefan Beller <sbeller@google.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Brandon Williams <bmwill@google.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [RFC/PATCH] ls-files: adding support for submodules
Date: Fri, 9 Sep 2016 16:47:45 -0700 [thread overview]
Message-ID: <CAGZ79kaWNykEAZcjZ2Y19j2_3TF+qcz+vb8zSi1U+me3k+06LA@mail.gmail.com> (raw)
In-Reply-To: <xmqqh99o8ypm.fsf@gitster.mtv.corp.google.com>
On Fri, Sep 9, 2016 at 4:01 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Brandon Williams <bmwill@google.com> writes:
>
>> Allow ls-files to recognize submodules in order to retrieve a list of
>> files from a repository's submodules. This is done by forking off a
>> process to recursively call ls-files on all submodules.
>
> While I see why "ls-files --recurse-submodules" sounds nice ("hey, I
> can get list of _all_ the files here"), and I am quite happy with
> the quality of implementation (not just the code but its
> documentation and test)
The plan is to hook the ls-files machinery into
git-grep as the way of obtaining files to grep for a pattern.
As git-grep has a thread pool already, getting the list of files
single threaded is more beneficial as e.g. calling git-grep recursively
for submodules, as then you may have a fork bomb.
>
>> diff --git a/t/t3007-ls-files-recurse-submodules.sh b/t/t3007-ls-files-recurse-submodules.sh
> We used to do that when we didn't know better.
>
Oops, a lot of stuff slipped through the first internal review.
next prev parent reply other threads:[~2016-09-09 23:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 21:53 [RFC/PATCH] ls-files: adding support for submodules Brandon Williams
2016-09-09 22:35 ` Jeff King
2016-09-09 22:40 ` Junio C Hamano
2016-09-09 23:01 ` Junio C Hamano
2016-09-09 23:47 ` Stefan Beller [this message]
2016-09-11 22:10 ` Junio C Hamano
2016-09-12 0:51 ` Jeff King
2016-09-12 0:52 ` Jeff King
2016-09-12 16:01 ` Junio C Hamano
[not found] ` <CAKoko1oSEac_Nr1SkRB=dM_r3Jnew1Et2ZKj716iU3JLyHe2GQ@mail.gmail.com>
2016-09-12 17:39 ` Brandon Williams
2016-09-12 1:47 ` Junio C Hamano
2016-09-13 0:33 ` [PATCH v2] " Brandon Williams
2016-09-13 3:35 ` Brandon Williams
2016-09-13 16:31 ` Junio C Hamano
2016-09-15 20:51 ` Junio C Hamano
2016-09-15 20:51 ` [PATCH 1/2] SQUASH??? Junio C Hamano
2016-09-15 20:51 ` [PATCH 2/2] SQUASH??? Undecided Junio C Hamano
2016-09-15 21:12 ` Stefan Beller
2016-09-15 21:37 ` Brandon Williams
2016-09-15 20:57 ` [PATCH v2] ls-files: adding support for submodules Junio C Hamano
2016-09-15 20:58 ` Junio C Hamano
2016-09-15 20:58 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGZ79kaWNykEAZcjZ2Y19j2_3TF+qcz+vb8zSi1U+me3k+06LA@mail.gmail.com \
--to=sbeller@google.com \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).