From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: index-pack outside of repository?
Date: Fri, 16 Dec 2016 09:52:51 -0800 [thread overview]
Message-ID: <xmqqd1gru5fw.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20161216022904.cjang6napnl2vkc6@sigill.intra.peff.net> (Jeff King's message of "Thu, 15 Dec 2016 21:29:04 -0500")
Jeff King <peff@peff.net> writes:
> On Thu, Dec 15, 2016 at 08:37:28PM -0500, Jeff King wrote:
>
>> But if this case really is just "if (from_stdin)" that's quite easy,
>> too.
>
> So here is that patch (with some associated refactoring and cleanups).
> This is conceptually independent of jk/no-looking-at-dotgit-outside-repo-final,
> though it should be fine to merge with that topic. The BUG will actually
> pass the new test, because it calls die, too. I wonder if we should die
> with a unique error code on BUGs, and catch them in test_must_fail
> similar to the way we catch signal death.
>
> [1/3]: t5000: extract nongit function to test-lib-functions.sh
> [2/3]: index-pack: complain when --stdin is used outside of a repo
> [3/3]: t: use nongit() function where applicable
I think 2/3 is a good change to ensure we get a reasonable error for
"index-pack --stdin", and 3/3 is a very good cleanup. Both of them
of course are enabled by 1/3.
We still fail "nongit git index-pack tmp.pack" with a BUG: though.
next prev parent reply other threads:[~2016-12-16 17:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-15 20:40 index-pack outside of repository? Jeff King
2016-12-16 0:13 ` Junio C Hamano
2016-12-16 1:37 ` Jeff King
2016-12-16 2:29 ` Jeff King
2016-12-16 2:30 ` [PATCH 1/3] t5000: extract nongit function to test-lib-functions.sh Jeff King
2016-12-16 2:30 ` [PATCH 2/3] index-pack: complain when --stdin is used outside of a repo Jeff King
2016-12-16 2:31 ` [PATCH 3/3] t: use nongit() function where applicable Jeff King
2016-12-16 17:52 ` Junio C Hamano [this message]
2016-12-16 17:59 ` index-pack outside of repository? Junio C Hamano
2016-12-16 18:01 ` Junio C Hamano
2016-12-16 21:43 ` Jeff King
2016-12-16 21:55 ` Junio C Hamano
2016-12-16 18:54 ` Junio C Hamano
2016-12-16 21:44 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqd1gru5fw.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).