From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: index-pack outside of repository?
Date: Fri, 16 Dec 2016 16:44:25 -0500 [thread overview]
Message-ID: <20161216214424.o3x4xqttrao3i73v@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqlgvfso16.fsf@gitster.mtv.corp.google.com>
On Fri, Dec 16, 2016 at 10:54:13AM -0800, Junio C Hamano wrote:
> I am tempted to suggest an intermediate step that comes before
> b1ef400eec ("setup_git_env: avoid blind fall-back to ".git"",
> 2016-10-20), which is the attached, and publish that as part of an
> official release. That way, we'll see what is broken without
> hurting people too much (unless they or their scripts care about
> extra message given to the standard error stream). I suspect that
> released Git has a slightly larger user base than what is cooked on
> 'next'.
>
> environment.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/environment.c b/environment.c
> index 0935ec696e..88f857331e 100644
> --- a/environment.c
> +++ b/environment.c
> @@ -167,8 +167,11 @@ static void setup_git_env(void)
> const char *replace_ref_base;
>
> git_dir = getenv(GIT_DIR_ENVIRONMENT);
> - if (!git_dir)
> + if (!git_dir) {
> + if (!startup_info->have_repository)
> + warning("BUG: please report this at git@vger.kernel.org");
> git_dir = DEFAULT_GIT_DIR_ENVIRONMENT;
> + }
Yes, I think this is a nice way to ease into the change. I wish I had
thought of it when doing the original series, and we could have shipped
it in v2.11. :)
-Peff
prev parent reply other threads:[~2016-12-16 21:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-15 20:40 index-pack outside of repository? Jeff King
2016-12-16 0:13 ` Junio C Hamano
2016-12-16 1:37 ` Jeff King
2016-12-16 2:29 ` Jeff King
2016-12-16 2:30 ` [PATCH 1/3] t5000: extract nongit function to test-lib-functions.sh Jeff King
2016-12-16 2:30 ` [PATCH 2/3] index-pack: complain when --stdin is used outside of a repo Jeff King
2016-12-16 2:31 ` [PATCH 3/3] t: use nongit() function where applicable Jeff King
2016-12-16 17:52 ` index-pack outside of repository? Junio C Hamano
2016-12-16 17:59 ` Junio C Hamano
2016-12-16 18:01 ` Junio C Hamano
2016-12-16 21:43 ` Jeff King
2016-12-16 21:55 ` Junio C Hamano
2016-12-16 18:54 ` Junio C Hamano
2016-12-16 21:44 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161216214424.o3x4xqttrao3i73v@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).