From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: index-pack outside of repository?
Date: Thu, 15 Dec 2016 20:37:28 -0500 [thread overview]
Message-ID: <20161216013728.in2dazshtarrnnq3@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqshpou3wt.fsf@gitster.mtv.corp.google.com>
On Thu, Dec 15, 2016 at 04:13:38PM -0800, Junio C Hamano wrote:
> > So I think complaining to the user is the right thing to do here. I
> > started to write a patch to have index-pack notice when it needs a repo
> > and doesn't have one, but the logic is actually a bit unclear. Do we
> > need to complain early _just_ when --stdin is specified, or does that
> > miss somes cases? Likewise, are there cases where --stdin can operate
> > without a repo? I couldn't think of any.
>
> I think there are two and only two major modes; --stdin wants to put
> the result in the repository it is working on, while the other mode
> takes a filename to deposit the result in, so the latter does not
> technically need a repository.
OK. That's easy to check for, then. Reverse-engineering that logic from
the actual calls in index-pack.c:final() is complicated. But certainly
basing it on --stdin is what I would have expected.
> > That strategy _might_ be a problem for some programs, which would want
> > to notice the issue early before doing work. But it seems like a
> > reasonable outcome for index-pack. Thoughts?
>
> That is, once we know which codepaths should require a repository, I
> think it is reasonable to add a check that is done earlier than the
> place where we currently try to see where we have one (which could
> be deep in the callchain). But we are all human and can miss things,
> so the BUG() thing is probably fine. We are cooking it exactly because
> we would want to find such corner cases we missed, no?
Right, that was my original intent in adding the BUG(): to catch
unhandled cases, and then do the appropriate thing earlier. I was just
questioning whether the appropriate thing in some cases might be dying
at the BUG(), just with a more friendly message. That has the benefit of
being very easy to implement, and never wrong (e.g., forbidding a case
that actually _doesn't_ need to look at the repo).
But if this case really is just "if (from_stdin)" that's quite easy,
too.
-Peff
next prev parent reply other threads:[~2016-12-16 1:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-15 20:40 index-pack outside of repository? Jeff King
2016-12-16 0:13 ` Junio C Hamano
2016-12-16 1:37 ` Jeff King [this message]
2016-12-16 2:29 ` Jeff King
2016-12-16 2:30 ` [PATCH 1/3] t5000: extract nongit function to test-lib-functions.sh Jeff King
2016-12-16 2:30 ` [PATCH 2/3] index-pack: complain when --stdin is used outside of a repo Jeff King
2016-12-16 2:31 ` [PATCH 3/3] t: use nongit() function where applicable Jeff King
2016-12-16 17:52 ` index-pack outside of repository? Junio C Hamano
2016-12-16 17:59 ` Junio C Hamano
2016-12-16 18:01 ` Junio C Hamano
2016-12-16 21:43 ` Jeff King
2016-12-16 21:55 ` Junio C Hamano
2016-12-16 18:54 ` Junio C Hamano
2016-12-16 21:44 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161216013728.in2dazshtarrnnq3@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).