From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: ab/commit-plug-leaks + ab/diff-free-more
Date: Thu, 24 Feb 2022 15:38:28 -0800 [thread overview]
Message-ID: <xmqqczjbj0nf.fsf@gitster.g> (raw)
In-Reply-To: <220224.86k0dkaaun.gmgdl@evledraar.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Thu, 24 Feb 2022 10:08:59 +0100")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> On Wed, Feb 23 2022, Junio C Hamano wrote:
>
>> * ab/commit-plug-leaks (2022-02-16) 2 commits
>> - commit: use strbuf_release() instead of UNLEAK()
>> - commit: fix "author_ident" leak
>>
>> Leakfixes in the top-level called-once function.
>>
>> Expecting a reroll.
>> I think UNLEAK->strbuf_release() is a regression.
>> source: <cover-0.2-00000000000-20220216T081844Z-avarab@gmail.com>
>
> After you noted that in [1] I followed-up in [2] giving reasons for
> wanting to keep that UNLEAK->strbuf_release() change. What do you think
> about that?
Do not count and aim to reduce the number of UNLEAK in builtin/
directory. Re-read [1] until you get it.
Thanks.
next prev parent reply other threads:[~2022-02-24 23:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 3:40 What's cooking in git.git (Feb 2022, #06; Wed, 23) Junio C Hamano
2022-02-24 9:08 ` ab/commit-plug-leaks + ab/diff-free-more (was: What's cooking in git.git (Feb 2022, #06; Wed, 23)) Ævar Arnfjörð Bjarmason
2022-02-24 23:38 ` Junio C Hamano [this message]
2022-02-24 9:11 ` ab/c99 + ab/hook-tests " Ævar Arnfjörð Bjarmason
2022-02-24 9:18 ` ab/object-file-api-updates " Ævar Arnfjörð Bjarmason
2022-02-24 17:48 ` ar/submodule-update (wa " Glen Choo
2022-02-24 19:55 ` Junio C Hamano
2022-02-24 19:11 ` jc/cat-file-batch-commands (was: " John Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqczjbj0nf.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).