From: Glen Choo <chooglen@google.com>
To: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Emily Shaffer" <emilyshaffer@google.com>
Subject: ar/submodule-update (wa Re: What's cooking in git.git (Feb 2022, #06; Wed, 23))
Date: Fri, 25 Feb 2022 01:48:55 +0800 [thread overview]
Message-ID: <kl6lmtig40l4.fsf@chooglen-macbookpro.roam.corp.google.com> (raw)
In-Reply-To: <xmqq1qztortk.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
> * ar/submodule-update (2022-02-10) 20 commits
> . fixup! submodule: move core cmd_update() logic to C
> . fixup! submodule--helper run-update-procedure: learn --remote
> . fixup! submodule--helper run-update-procedure: remove --suboid
> . submodule: move core cmd_update() logic to C
> . submodule--helper: reduce logic in run_update_procedure()
> . submodule--helper: move functions around
> . submodule--helper update-clone: learn --init
> . submodule--helper: remove ensure-core-worktree
> . submodule--helper run-update-procedure: learn --remote
> . submodule--helper run-update-procedure: remove --suboid
> . submodule--helper: reorganize code for sh to C conversion
> . submodule--helper: remove update-module-mode
> . submodule tests: test for init and update failure output
> . submodule--helper: don't use bitfield indirection for parse_options()
> . builtin/submodule--helper.c: rename option variables to "opt"
> . builtin/submodule--helper.c: reformat designated initializers
> . submodule--helper: run update using child process struct
> . submodule--helper: allow setting superprefix for init_submodule()
> . submodule--helper: refactor get_submodule_displaypath()
> . submodule--helper: get remote names from any repository
>
> Rewrite of "git submodule update" in C.
>
> Does not seem to play well with other topics in flight, with heavy conflicts.
> cf. <xmqqv8xj71mt.fsf@gitster.g>
> source: <20220210092833.55360-1-chooglen@google.com>
I've dug a little deeper, and I think my plan to reroll this as two
series [1] makes sense:
1. Small, obvious conversions from sh->C.
2. Finalizing the conversion.
(1) has only trivial conflicts, and is relatively easy to review, so I
expect that to go through quickly.
This should also buy some time to finalize those other topics and
hopefully make coordination simpler.
[1] https://lore.kernel.org/git/kl6l4k4y59p4.fsf@chooglen-macbookpro.roam.corp.google.com
next prev parent reply other threads:[~2022-02-24 17:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 3:40 What's cooking in git.git (Feb 2022, #06; Wed, 23) Junio C Hamano
2022-02-24 9:08 ` ab/commit-plug-leaks + ab/diff-free-more (was: What's cooking in git.git (Feb 2022, #06; Wed, 23)) Ævar Arnfjörð Bjarmason
2022-02-24 23:38 ` ab/commit-plug-leaks + ab/diff-free-more Junio C Hamano
2022-02-24 9:11 ` ab/c99 + ab/hook-tests (was: What's cooking in git.git (Feb 2022, #06; Wed, 23)) Ævar Arnfjörð Bjarmason
2022-02-24 9:18 ` ab/object-file-api-updates " Ævar Arnfjörð Bjarmason
2022-02-24 17:48 ` Glen Choo [this message]
2022-02-24 19:55 ` ar/submodule-update (wa " Junio C Hamano
2022-02-24 19:11 ` jc/cat-file-batch-commands (was: " John Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=kl6lmtig40l4.fsf@chooglen-macbookpro.roam.corp.google.com \
--to=chooglen@google.com \
--cc=avarab@gmail.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).