From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Jiang Xin <worldhello.net@gmail.com>
Subject: ab/object-file-api-updates (was: What's cooking in git.git (Feb 2022, #06; Wed, 23))
Date: Thu, 24 Feb 2022 10:18:43 +0100 [thread overview]
Message-ID: <220224.867d9kaabe.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <xmqq1qztortk.fsf@gitster.g>
On Wed, Feb 23 2022, Junio C Hamano wrote:
> * ab/object-file-api-updates (2022-02-04) 11 commits
> - object-file API: pass an enum to read_object_with_reference()
> - object-file.c: add a literal version of write_object_file_prepare()
> - object-file API: have hash_object_file() take "enum object_type"
> - object API: rename hash_object_file_literally() to write_*()
> - object-file API: split up and simplify check_object_signature()
> - object API: make check_object_signature() oideq()-like, move docs
> - object API: correct "buf" v.s. "map" mismatch in *.c and *.h
> - object-file API: have write_object_file() take "enum object_type"
> - object-file API: add a format_object_header() function
> - object-file API: return "void", not "int" from hash_object_file()
> - object-file.c: split up declaration of unrelated variables
>
> Object-file API shuffling.
> source: <cover-v2-00.11-00000000000-20220204T135005Z-avarab@gmail.com>
There's an outstanding v3 of this that hasn't been picked up & addresses
earlier feedback of yours[1].
I think with that v3 this should be ready to advance.
Jiang Xin had feedback in [2] about avoiding some casts by having the
added functions take a "void *" insted of a "char *", which as I replied
to I think we'd like to not do, and is consistent with how we tend to
handle those casting issues in existing code.
1. https://lore.kernel.org/git/cover-v3-00.12-00000000000-20220204T234435Z-avarab@gmail.com/
2. https://lore.kernel.org/git/20220217045943.30223-1-worldhello.net@gmail.com/
next prev parent reply other threads:[~2022-02-24 9:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 3:40 What's cooking in git.git (Feb 2022, #06; Wed, 23) Junio C Hamano
2022-02-24 9:08 ` ab/commit-plug-leaks + ab/diff-free-more (was: What's cooking in git.git (Feb 2022, #06; Wed, 23)) Ævar Arnfjörð Bjarmason
2022-02-24 23:38 ` ab/commit-plug-leaks + ab/diff-free-more Junio C Hamano
2022-02-24 9:11 ` ab/c99 + ab/hook-tests (was: What's cooking in git.git (Feb 2022, #06; Wed, 23)) Ævar Arnfjörð Bjarmason
2022-02-24 9:18 ` Ævar Arnfjörð Bjarmason [this message]
2022-02-24 17:48 ` ar/submodule-update (wa " Glen Choo
2022-02-24 19:55 ` Junio C Hamano
2022-02-24 19:11 ` jc/cat-file-batch-commands (was: " John Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=220224.867d9kaabe.gmgdl@evledraar.gmail.com \
--to=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=worldhello.net@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).