git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>,
	git@vger.kernel.org, avarab@gmail.com,
	"Randall S . Becker" <rsbecker@nexbridge.com>
Subject: Re: [PATCH] wrapper: remove xunsetenv()
Date: Fri, 29 Oct 2021 14:58:48 -0700	[thread overview]
Message-ID: <xmqqbl37ijc7.fsf@gitster.g> (raw)
In-Reply-To: <YXxs4NZmpjhRkoYA@coredump.intra.peff.net> (Jeff King's message of "Fri, 29 Oct 2021 17:51:28 -0400")

Jeff King <peff@peff.net> writes:

> However, according to the unsetenv() manpage:
>
>   Prior to glibc 2.2.2, unsetenv() was prototyped as returning void;
>   more recent glibc versions follow the POSIX.1-compliant prototype
>   shown in the SYNOPSIS.
>
> So it is POSIX to return an int, but that gives us at least one platform
> where unsetenv() returns void (or used to). glibc 2.2.2 is 2001-era, so
> that may be old enough that we don't care. But it makes me wonder if
> other older or obscure platforms will run into this.

Ahh, OK.  Well, we will hear from them soon enough.  It is not like
this is anything urgent.

Thanks.


  reply	other threads:[~2021-10-29 21:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <013a01d7cd092d91cb088b5610nexbridge.com>
2021-10-29 21:27 ` [PATCH] wrapper: remove xunsetenv() Carlo Marcelo Arenas Belón
2021-10-29 21:37   ` Jeff King
2021-10-29 21:43     ` rsbecker
2021-10-29 21:50       ` Carlo Arenas
2021-10-29 21:56         ` Junio C Hamano
2021-10-29 21:51     ` Jeff King
2021-10-29 21:58       ` Junio C Hamano [this message]
2021-10-29 22:00         ` Jeff King
2021-10-29 22:03           ` Junio C Hamano
2021-10-29 23:11             ` Jeff King
2021-10-29 22:01         ` rsbecker
2021-10-29 22:29           ` Junio C Hamano
2021-10-30  0:13             ` rsbecker
2021-10-29 21:37   ` rsbecker
2021-10-29 21:43     ` Carlo Arenas
2021-10-29 21:48       ` rsbecker
2021-10-29 21:53   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqbl37ijc7.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=carenas@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=rsbecker@nexbridge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).