From: <rsbecker@nexbridge.com>
To: "'Jeff King'" <peff@peff.net>,
"'Carlo Marcelo Arenas Belón'" <carenas@gmail.com>
Cc: <git@vger.kernel.org>, <avarab@gmail.com>
Subject: RE: [PATCH] wrapper: remove xunsetenv()
Date: Fri, 29 Oct 2021 17:43:25 -0400 [thread overview]
Message-ID: <014901d7cd0e$042a3470$0c7e9d50$@nexbridge.com> (raw)
In-Reply-To: <YXxpjLhiguq4HY6g@coredump.intra.peff.net>
On October 29, 2021 5:37 PM, Jeff King wrote:
> On Fri, Oct 29, 2021 at 02:27:05PM -0700, Carlo Marcelo Arenas Belón wrote:
>
> > Platforms that are using the git compatibility layer for unsetenv use
> > void as a return value for unsetenv(), so any function that checks for
> > a return value will fail to build.
>
> Good catch.
>
> > Remove the unused wrapper function.
>
> I don't mind removing this if nobody is using it, but doesn't your first paragraph
> argue that our definition of gitunsetenv() is just wrong?
> I.e., it should return an int, even if it is always "0"?
>
> Or is it a portability question? I.e., are there platforms where
> unsetenv() also returns void, in which case we must make sure nobody ever
> looks at its return value (and xunsetenv() is therefore a wrong direction)?
At least on NonStop x86, it is
int unsetenv(const char *name);
--Randall
next prev parent reply other threads:[~2021-10-29 21:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <013a01d7cd092d91cb088b5610nexbridge.com>
2021-10-29 21:27 ` [PATCH] wrapper: remove xunsetenv() Carlo Marcelo Arenas Belón
2021-10-29 21:37 ` Jeff King
2021-10-29 21:43 ` rsbecker [this message]
2021-10-29 21:50 ` Carlo Arenas
2021-10-29 21:56 ` Junio C Hamano
2021-10-29 21:51 ` Jeff King
2021-10-29 21:58 ` Junio C Hamano
2021-10-29 22:00 ` Jeff King
2021-10-29 22:03 ` Junio C Hamano
2021-10-29 23:11 ` Jeff King
2021-10-29 22:01 ` rsbecker
2021-10-29 22:29 ` Junio C Hamano
2021-10-30 0:13 ` rsbecker
2021-10-29 21:37 ` rsbecker
2021-10-29 21:43 ` Carlo Arenas
2021-10-29 21:48 ` rsbecker
2021-10-29 21:53 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='014901d7cd0e$042a3470$0c7e9d50$@nexbridge.com' \
--to=rsbecker@nexbridge.com \
--cc=avarab@gmail.com \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).