git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: <rsbecker@nexbridge.com>
To: "'Carlo Arenas'" <carenas@gmail.com>
Cc: <git@vger.kernel.org>, <avarab@gmail.com>
Subject: RE: [PATCH] wrapper: remove xunsetenv()
Date: Fri, 29 Oct 2021 17:48:41 -0400	[thread overview]
Message-ID: <015401d7cd0e$c05b63d0$41122b70$@nexbridge.com> (raw)
In-Reply-To: <CAPUEspht5wFnsLMxzaq5JNJV2eh_YRB5PZ4UWXNMTJpG3gOf8w@mail.gmail.com>

On October 29, 2021 5:43 PM, Carlo Arenas wrote:
> On Fri, Oct 29, 2021 at 2:37 PM <rsbecker@nexbridge.com> wrote:
> >
> > I will be submitting a separate patch to turn off NO_SETENV and
> NO_UNSETENV for the NonStop x86 platform, where the calls have been
> supported since October 2020. The ia64 platform will have to continue to use
> the compat layer.
> 
> The right place to add that logic is most likely in config.mak.uname; see all the
> other conditions that match based on version as a guideline.

Already there. I just want to make sure everything is fine on the older box. This will be it, but I'm looking at whether I can get rid of any other switches at the same time:

diff --git a/config.mak.uname b/config.mak.uname
index 3236a491..fdcc4690 100644
--- a/config.mak.uname
+++ b/config.mak.uname
@@ -569,8 +569,11 @@ ifeq ($(uname_S),NONSTOP_KERNEL)
        NO_STRCASESTR = YesPlease
        NO_MEMMEM = YesPlease
        NO_STRLCPY = YesPlease
-       NO_SETENV = YesPlease
-       NO_UNSETENV = YesPlease
+       ifeq ($(uname_R),J06)
+               # setenv and unsetenv are not supported on J-series
+               NO_SETENV = YesPlease
+               NO_UNSETENV = YesPlease
+       endif
        NO_MKDTEMP = YesPlease
        # Currently libiconv-1.9.1.
        OLD_ICONV = UnfortunatelyYes


  reply	other threads:[~2021-10-29 21:48 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <013a01d7cd092d91cb088b5610nexbridge.com>
2021-10-29 21:27 ` [PATCH] wrapper: remove xunsetenv() Carlo Marcelo Arenas Belón
2021-10-29 21:37   ` Jeff King
2021-10-29 21:43     ` rsbecker
2021-10-29 21:50       ` Carlo Arenas
2021-10-29 21:56         ` Junio C Hamano
2021-10-29 21:51     ` Jeff King
2021-10-29 21:58       ` Junio C Hamano
2021-10-29 22:00         ` Jeff King
2021-10-29 22:03           ` Junio C Hamano
2021-10-29 23:11             ` Jeff King
2021-10-29 22:01         ` rsbecker
2021-10-29 22:29           ` Junio C Hamano
2021-10-30  0:13             ` rsbecker
2021-10-29 21:37   ` rsbecker
2021-10-29 21:43     ` Carlo Arenas
2021-10-29 21:48       ` rsbecker [this message]
2021-10-29 21:53   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='015401d7cd0e$c05b63d0$41122b70$@nexbridge.com' \
    --to=rsbecker@nexbridge.com \
    --cc=avarab@gmail.com \
    --cc=carenas@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).