git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Philip Oakley" <philipoakley@iee.org>
Cc: "Git List" <git@vger.kernel.org>,
	"Eric Sunshine" <sunshine@sunshineco.com>
Subject: Re: [PATCH 3/3] doc: give examples for send-email cc-cmd operation
Date: Mon, 20 Jul 2015 15:37:08 -0700	[thread overview]
Message-ID: <xmqqa8uqxxpn.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <996C8C8A69844E44890D09811C57DAC8@PhilipOakley> (Philip Oakley's message of "Mon, 20 Jul 2015 22:35:01 +0100")

"Philip Oakley" <philipoakley@iee.org> writes:

> We seem to be going round in circles.

I do not think so.

> Currently the --cc-cmd isn't well documented.

Yes, I agree.

> I was trying to use, essentially, 'cat list.txt' as the command, which
> should work according to the current doc, which says nothing about
> how/if the patch file is to be passed to the command.

I've already agreed in the message you are responding to that the
current documentation is sketchy and invite mistakes like yours.
And that is why this series exists, isn't it?

> The question are:
> What should the "command" look like. (can it be a command, or does it
> have to be a script??)
> How should the patch/patchfile be passed - what should the
> documentation guarantee?

Yes, I think I already answered that, no?

>>    The program that is specified by `cc-cmd` is invoked by `git
>>    send-email` with the name of the patch file as an argument;
>>    the program can read from it and customize its output based on
>>    what the patch file contains.
>>
>> or something like that, perhaps.

We do not care if that program is scripted, or written in java and
compiled.  It will find the patch in argv[1].  It is up to the
program if it uses that input to customize its output, or it just
outputs a hardcoded list of addresses.

That is the only guarantee we would want to give.

  reply	other threads:[~2015-07-20 22:37 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-20 18:26 [PATCH 0/3] Update send-email cc-cmd documentation Philip Oakley
2015-07-20 18:26 ` [PATCH 1/3] doc: convert send-email option headings to nouns Philip Oakley
2015-07-20 18:26 ` [PATCH 2/3] doc: send-email; expand on the meaning of 'auto-cc' Philip Oakley
2015-07-20 18:34   ` Eric Sunshine
2015-07-20 18:26 ` [PATCH 2/3] doc: send-email; expand oon " Philip Oakley
2015-07-20 18:55   ` Philip Oakley
2015-07-20 18:26 ` [PATCH 3/3] doc: give examples for send-email cc-cmd operation Philip Oakley
2015-07-20 18:50   ` Eric Sunshine
2015-07-20 19:14     ` Eric Sunshine
2015-07-20 20:26       ` Eric Sunshine
2015-07-20 19:36     ` Philip Oakley
2015-07-20 20:36       ` Eric Sunshine
2015-07-20 19:59   ` Junio C Hamano
2015-07-20 21:35     ` Philip Oakley
2015-07-20 22:37       ` Junio C Hamano [this message]
2015-07-20 22:59         ` Junio C Hamano
2015-07-21 22:48           ` Philip Oakley
2015-07-22 18:58             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqa8uqxxpn.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=philipoakley@iee.org \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).