From: Eric Sunshine <sunshine@sunshineco.com>
To: Philip Oakley <philipoakley@iee.org>
Cc: Git List <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 3/3] doc: give examples for send-email cc-cmd operation
Date: Mon, 20 Jul 2015 16:36:22 -0400 [thread overview]
Message-ID: <CAPig+cRbRfOyyx7bx4hM9akN_cO5geZo=cy0+JAprBpnm6qQcw@mail.gmail.com> (raw)
In-Reply-To: <1E307B9A21744983970834F69116F358@PhilipOakley>
On Mon, Jul 20, 2015 at 3:36 PM, Philip Oakley <philipoakley@iee.org> wrote:
> From: "Eric Sunshine" <sunshine@sunshineco.com>
>>> + echo <<\EOF
>>> + person1@example.com
>>> + person2@example.com
>>> + EOF
>>
>> I don't know if it deserves mention that the script must be executable
>> (chmod +x) or should we assume that readers are smart enough to
>> understand this implicitly? (It probably should be mentioned.)
>
> It's there, but it's after the wrap-around. Maybe
> s/(executable)/(must be executable: `chmod +x`)/
> to be fully pedantic.
I did see the "(executable)", but wasn't sure if it meant executable
in the 'chmod +x' sense or executable as another name for "program".
>> This entire above text about "cat $addressfile" seems awfully
>> inappropriate for a manual page, especially the bit about the terrible
>> "cat $file #" hack.
>
> Given that this invocation is why this all kicked off ...
> 'cat list.txt', being the most simple of commands and a first cargo-cult try
> for many, I definitely think it's worthwhile including somehow.
>
> Perhaps one needs to be more direct with the right invocation.
>
> "A simple `--cc-cmd='cat list.txt #'` is a quick-and-dirty way of using an
> address list, while ignoring the patch content."
It seems utterly sinful to promulgate this sort of hack to a wider
audience. If reading addresses from a file is likely to be a common
need, then perhaps it ought to have direct support in git-send-email
(via a new command-line option or something).
Also, this all may be moot once rl/send-email-aliases[1] lands in a
release since users will then be able to say:
--cc="$(cat recipients.txt)"
provided that the email addresses in recipients.txt are
comma-separated and a POSIX-like shell is being used. Perhaps that
deserves an example in the documentation?
[1]: b1c8a11 (send-email: allow multiple emails using --cc, --to and
--bcc, 2015-06-30)
next prev parent reply other threads:[~2015-07-20 20:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 18:26 [PATCH 0/3] Update send-email cc-cmd documentation Philip Oakley
2015-07-20 18:26 ` [PATCH 1/3] doc: convert send-email option headings to nouns Philip Oakley
2015-07-20 18:26 ` [PATCH 2/3] doc: send-email; expand on the meaning of 'auto-cc' Philip Oakley
2015-07-20 18:34 ` Eric Sunshine
2015-07-20 18:26 ` [PATCH 2/3] doc: send-email; expand oon " Philip Oakley
2015-07-20 18:55 ` Philip Oakley
2015-07-20 18:26 ` [PATCH 3/3] doc: give examples for send-email cc-cmd operation Philip Oakley
2015-07-20 18:50 ` Eric Sunshine
2015-07-20 19:14 ` Eric Sunshine
2015-07-20 20:26 ` Eric Sunshine
2015-07-20 19:36 ` Philip Oakley
2015-07-20 20:36 ` Eric Sunshine [this message]
2015-07-20 19:59 ` Junio C Hamano
2015-07-20 21:35 ` Philip Oakley
2015-07-20 22:37 ` Junio C Hamano
2015-07-20 22:59 ` Junio C Hamano
2015-07-21 22:48 ` Philip Oakley
2015-07-22 18:58 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cRbRfOyyx7bx4hM9akN_cO5geZo=cy0+JAprBpnm6qQcw@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=philipoakley@iee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).