From: "Philip Oakley" <philipoakley@iee.org>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: "Git List" <git@vger.kernel.org>,
"Eric Sunshine" <sunshine@sunshineco.com>
Subject: Re: [PATCH 3/3] doc: give examples for send-email cc-cmd operation
Date: Tue, 21 Jul 2015 23:48:48 +0100 [thread overview]
Message-ID: <11647308F0684851A72DDF51A486D11D@PhilipOakley> (raw)
In-Reply-To: xmqq615exwou.fsf@gitster.dls.corp.google.com
From: "Junio C Hamano" <gitster@pobox.com>
> Junio C Hamano <gitster@pobox.com> writes:
>
>>> I was trying to use, essentially, 'cat list.txt' as the command,...
>
> One thing that needs to be made clear is that I do not think we want
> to encourage `cat list.txt #` abuse in the first place.
OK [1]
> It is an
> unacceptable hack for us to encourage in the longer term. It may
> happen to work with the current implementation, but it does so
> merely by depending on the implementation too much.
>
> If it is so common to want to spray all your patches to exactly the
> same list of recipients that is unconditionally determined, having
It wasn't 'unconditional spraying' ;-), rather I'd carefully select who
to send to for each series, previously with multiple cc=".." on the
command line.
> multiple sendemail.cc configuration variables, which are cumulative,
> is already one way to do so, and you do not have to type such a long
> option "--cc-cmd='cat $filename'" every time.
>
> And if you do not want configuration for some reason, and having a
> list of addresses in a flat file is so common, we could have a new
> option "--cc-list=$filename" to support that use case. I however
> doubt anything that starts with "First you make a list of addresses
> in a flat file, and then do this" is a good solution.
For a longer series, a list will still need collating by the OP somehow,
but I don't think that alone would justify a new option.
>
> I would think that it would probably be the best way to address "I
> often want to cc these recipients, but not always" is to keep a list
> of aliases, each entry of which expands to the recipients, and say
> "--cc=group" from the command line to have it expanded to the set of
> recipients.
>
[1] You mentioned in the previous email the script command argv[] array,
which I hadn't heard of (for a script), having been used the $1, $2,
method.
Given that new understanding, IIUC the proposal is that the garantee is
the "--cc-cmd" should be a single command/script name, with the
patchfilename passed as $1, and that a 'string string' for
interpretation would now be deprecated.
I'll see about a shorter doc patch that restricts itself to just the
base aspects, if that would be acceptable?
--
Philip
next prev parent reply other threads:[~2015-07-21 22:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 18:26 [PATCH 0/3] Update send-email cc-cmd documentation Philip Oakley
2015-07-20 18:26 ` [PATCH 1/3] doc: convert send-email option headings to nouns Philip Oakley
2015-07-20 18:26 ` [PATCH 2/3] doc: send-email; expand on the meaning of 'auto-cc' Philip Oakley
2015-07-20 18:34 ` Eric Sunshine
2015-07-20 18:26 ` [PATCH 2/3] doc: send-email; expand oon " Philip Oakley
2015-07-20 18:55 ` Philip Oakley
2015-07-20 18:26 ` [PATCH 3/3] doc: give examples for send-email cc-cmd operation Philip Oakley
2015-07-20 18:50 ` Eric Sunshine
2015-07-20 19:14 ` Eric Sunshine
2015-07-20 20:26 ` Eric Sunshine
2015-07-20 19:36 ` Philip Oakley
2015-07-20 20:36 ` Eric Sunshine
2015-07-20 19:59 ` Junio C Hamano
2015-07-20 21:35 ` Philip Oakley
2015-07-20 22:37 ` Junio C Hamano
2015-07-20 22:59 ` Junio C Hamano
2015-07-21 22:48 ` Philip Oakley [this message]
2015-07-22 18:58 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11647308F0684851A72DDF51A486D11D@PhilipOakley \
--to=philipoakley@iee.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).