From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Jeff King" <peff@peff.net>,
"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH] perf: work around the tested repo having an index.lock
Date: Mon, 05 Jun 2017 11:02:18 +0900 [thread overview]
Message-ID: <xmqqa85nur85.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAP8UFD1u-C-T2X+H8WxxB7O+ajcGfygRBLN0t7+zJcOh_SrvFQ@mail.gmail.com> (Christian Couder's message of "Sun, 4 Jun 2017 09:37:29 +0200")
Christian Couder <christian.couder@gmail.com> writes:
> On Sun, Jun 4, 2017 at 2:00 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>>
>>>> My feeling exactly. Diagnosing and failing upfront saying "well you
>>>> made a copy but it is not suitable for testing" sounds more sensible
>>>> at lesat to me.
>>>
>>> This change makes the repo suitable for testing when it wasn't before.
>>
>> Perhaps "not suitable" was a bit too vague.
>>
>> The copy you made is not in a consistent state that is good for
>> testing. This change may declare that it is now in a consistent
>> state, but removal of a single *.lock file does not make it so. We
>> do not know what other transient inconsistency the resulting copy
>> has; it is inherent to git-unaware copy---that is why we discouraged
>> and removed rsync transport after all.
>
> If we don't like git-unaware copies, maybe we should go back to the
> reasons why we are making one here.
We do need git-unaware bit-for-bit copy for testing, because you may
want to see the effect of unreachable objects, for example.
It's just that git-unaware copies, because it cannot be an atomic
snapshot, can introduce inconsistencies the original repository did
not have, rendering the result ineffective.
next prev parent reply other threads:[~2017-06-05 2:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 10:33 [PATCH] perf: work around the tested repo having an index.lock Ævar Arnfjörð Bjarmason
2017-06-02 18:45 ` Jeff King
2017-06-02 20:12 ` Ævar Arnfjörð Bjarmason
2017-06-02 23:52 ` Junio C Hamano
2017-06-03 16:24 ` Ævar Arnfjörð Bjarmason
2017-06-04 0:00 ` Junio C Hamano
2017-06-04 0:51 ` Junio C Hamano
2017-06-04 7:37 ` Christian Couder
2017-06-04 7:55 ` Ævar Arnfjörð Bjarmason
2017-06-04 8:23 ` Jeff King
2017-06-05 2:02 ` Junio C Hamano [this message]
2017-06-05 6:25 ` Christian Couder
2017-06-04 8:29 ` Jeff King
2017-06-05 2:04 ` Junio C Hamano
2017-06-04 2:04 ` Junio C Hamano
2017-06-04 8:37 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa85nur85.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).