* [PATCH] mailmap: update brandon williams's email address @ 2018-12-07 20:56 Brandon Williams 2018-12-07 21:40 ` Jonathan Nieder 0 siblings, 1 reply; 12+ messages in thread From: Brandon Williams @ 2018-12-07 20:56 UTC (permalink / raw) To: git; +Cc: Brandon Williams Signed-off-by: Brandon Williams <bwilliams.eng@gmail.com> --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap b/.mailmap index eb7b5fc7b..247a3deb7 100644 --- a/.mailmap +++ b/.mailmap @@ -27,6 +27,7 @@ Ben Walton <bdwalton@gmail.com> <bwalton@artsci.utoronto.ca> Benoit Sigoure <tsunanet@gmail.com> <tsuna@lrde.epita.fr> Bernt Hansen <bernt@norang.ca> <bernt@alumni.uwaterloo.ca> Brandon Casey <drafnel@gmail.com> <casey@nrlssc.navy.mil> +Brandon Williams <bwilliams.eng@gmail.com> <bmwill@google.com> brian m. carlson <sandals@crustytoothpaste.net> brian m. carlson <sandals@crustytoothpaste.net> <sandals@crustytoothpaste.ath.cx> Bryan Larsen <bryan@larsen.st> <bryan.larsen@gmail.com> -- 2.19.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] mailmap: update brandon williams's email address 2018-12-07 20:56 [PATCH] mailmap: update brandon williams's email address Brandon Williams @ 2018-12-07 21:40 ` Jonathan Nieder 2018-12-07 22:11 ` Stefan Beller 0 siblings, 1 reply; 12+ messages in thread From: Jonathan Nieder @ 2018-12-07 21:40 UTC (permalink / raw) To: Brandon Williams; +Cc: git, Brandon Williams Brandon Williams wrote: > Signed-off-by: Brandon Williams <bwilliams.eng@gmail.com> > --- > .mailmap | 1 + > 1 file changed, 1 insertion(+) I can confirm that this is indeed the same person. Reviewed-by: Jonathan Nieder <jrnieder@gmail.com> Welcome back! ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] mailmap: update brandon williams's email address 2018-12-07 21:40 ` Jonathan Nieder @ 2018-12-07 22:11 ` Stefan Beller 2018-12-07 22:22 ` Jonathan Nieder 2018-12-08 6:08 ` Junio C Hamano 0 siblings, 2 replies; 12+ messages in thread From: Stefan Beller @ 2018-12-07 22:11 UTC (permalink / raw) To: Jonathan Nieder; +Cc: bwilliamseng, git, bwilliams.eng On Fri, Dec 7, 2018 at 1:40 PM Jonathan Nieder <jrnieder@gmail.com> wrote: > > Brandon Williams wrote: > > > Signed-off-by: Brandon Williams <bwilliams.eng@gmail.com> > > --- > > .mailmap | 1 + > > 1 file changed, 1 insertion(+) > > I can confirm that this is indeed the same person. What would be more of interest is why we'd be interested in this patch as there is no commit/patch sent by Brandon with this email in gits history. Is that so you get cc'd on your private address and can follow things you worked on without being subscribed to the mailing list? (I'd be interested to see the use case in the commit message;) Thanks, Stefan ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] mailmap: update brandon williams's email address 2018-12-07 22:11 ` Stefan Beller @ 2018-12-07 22:22 ` Jonathan Nieder 2019-01-18 16:57 ` Jeff King 2018-12-08 6:08 ` Junio C Hamano 1 sibling, 1 reply; 12+ messages in thread From: Jonathan Nieder @ 2018-12-07 22:22 UTC (permalink / raw) To: Stefan Beller; +Cc: bwilliamseng, git, bwilliams.eng Hi, Stefan Beller wrote: > What would be more of interest is why we'd be interested in this patch > as there is no commit/patch sent by Brandon with this email in gits history. I think there's an implicit assumption in this question that isn't spelled out. Do I understand correctly that you're saying the main purpose of .mailmap is to figure out whether two commits are by the same author? My own uses of .mailmap primarily have a different purpose: to find out the preferred contact address for the author of a given commit. Thanks, Jonathan ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] mailmap: update brandon williams's email address 2018-12-07 22:22 ` Jonathan Nieder @ 2019-01-18 16:57 ` Jeff King 2019-01-18 18:16 ` Junio C Hamano 0 siblings, 1 reply; 12+ messages in thread From: Jeff King @ 2019-01-18 16:57 UTC (permalink / raw) To: Jonathan Nieder; +Cc: Stefan Beller, bwilliamseng, git, bwilliams.eng On Fri, Dec 07, 2018 at 02:22:25PM -0800, Jonathan Nieder wrote: > Stefan Beller wrote: > > > What would be more of interest is why we'd be interested in this patch > > as there is no commit/patch sent by Brandon with this email in gits history. > > I think there's an implicit assumption in this question that isn't > spelled out. Do I understand correctly that you're saying the main > purpose of .mailmap is to figure out whether two commits are by the > same author? > > My own uses of .mailmap primarily have a different purpose: to find > out the preferred contact address for the author of a given commit. I just had to cc Brandon and manually look up his email address, which made me wonder what ever happened to this patch. :) FWIW, I also use mailmap to find contact email addresses, with: $ git help who 'who' is aliased to '!sh -c 'git --no-pager log -1 --format="%an <%aE>" --author="$1" -i' -' So lacking another such registry, I'd like to add my support for using mailmap for this purpose. -Peff ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] mailmap: update brandon williams's email address 2019-01-18 16:57 ` Jeff King @ 2019-01-18 18:16 ` Junio C Hamano 2019-01-18 18:38 ` Jeff King 0 siblings, 1 reply; 12+ messages in thread From: Junio C Hamano @ 2019-01-18 18:16 UTC (permalink / raw) To: Jeff King Cc: Jonathan Nieder, Stefan Beller, bwilliamseng, git, bwilliams.eng Jeff King <peff@peff.net> writes: > I just had to cc Brandon and manually look up his email address, which > made me wonder what ever happened to this patch. :) d076ad13 ("Merge branch 'bw/mailmap'", 2019-01-14) ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] mailmap: update brandon williams's email address 2019-01-18 18:16 ` Junio C Hamano @ 2019-01-18 18:38 ` Jeff King 0 siblings, 0 replies; 12+ messages in thread From: Jeff King @ 2019-01-18 18:38 UTC (permalink / raw) To: Junio C Hamano Cc: Jonathan Nieder, Stefan Beller, bwilliamseng, git, bwilliams.eng On Fri, Jan 18, 2019 at 10:16:33AM -0800, Junio C Hamano wrote: > Jeff King <peff@peff.net> writes: > > > I just had to cc Brandon and manually look up his email address, which > > made me wonder what ever happened to this patch. :) > > d076ad13 ("Merge branch 'bw/mailmap'", 2019-01-14) Oh, heh. False alarm: I was looking up his address after bisecting back to a failure from last year. And my "who" alias walks from the current HEAD. It should probably choose a known-current point like "origin/master". Sorry for the noise! -Peff ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] mailmap: update brandon williams's email address 2018-12-07 22:11 ` Stefan Beller 2018-12-07 22:22 ` Jonathan Nieder @ 2018-12-08 6:08 ` Junio C Hamano 2018-12-08 6:51 ` Brandon Williams ` (2 more replies) 1 sibling, 3 replies; 12+ messages in thread From: Junio C Hamano @ 2018-12-08 6:08 UTC (permalink / raw) To: Stefan Beller; +Cc: Jonathan Nieder, bwilliamseng, git, bwilliams.eng Stefan Beller <sbeller@google.com> writes: > On Fri, Dec 7, 2018 at 1:40 PM Jonathan Nieder <jrnieder@gmail.com> wrote: >> >> Brandon Williams wrote: >> >> > Signed-off-by: Brandon Williams <bwilliams.eng@gmail.com> >> > --- >> > .mailmap | 1 + >> > 1 file changed, 1 insertion(+) >> >> I can confirm that this is indeed the same person. > > What would be more of interest is why we'd be interested in this patch > as there is no commit/patch sent by Brandon with this email in gits history. Once I "git am" the message that began this thread, there will be a commit under this new ident, so that would be somewhat a moot point. If this were "Jonathan asked Brandon if we want to record an address we can reach him in our .mailmap file and sent a patch to add one", then the story is different, and I tend to agree with you that such a patch is more or less pointless. That's not the purpose of the mailmap file. Not until git-send-email learns to use that file to rewrite To/cc/etc to the "canonical" addresses, anyway ;-) I am not sure if there are people whose "canonical" address to be used as the author is not necessarily the best address they want to get their e-mails at, though. If we can be reasonably sure that the set of such people is empty, then people can take the above mention about send-email as a hint about a low-hanging fruit ;-) Thanks. ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] mailmap: update brandon williams's email address 2018-12-08 6:08 ` Junio C Hamano @ 2018-12-08 6:51 ` Brandon Williams 2018-12-10 8:36 ` Johannes Schindelin 2018-12-08 8:25 ` Duy Nguyen 2018-12-08 12:18 ` Ævar Arnfjörð Bjarmason 2 siblings, 1 reply; 12+ messages in thread From: Brandon Williams @ 2018-12-08 6:51 UTC (permalink / raw) To: gitster; +Cc: sbeller, jrnieder, git On Fri, Dec 7, 2018 at 10:08 PM Junio C Hamano <gitster@pobox.com> wrote: > > Stefan Beller <sbeller@google.com> writes: > > > On Fri, Dec 7, 2018 at 1:40 PM Jonathan Nieder <jrnieder@gmail.com> wrote: > >> > >> Brandon Williams wrote: > >> > >> > Signed-off-by: Brandon Williams <bwilliams.eng@gmail.com> > >> > --- > >> > .mailmap | 1 + > >> > 1 file changed, 1 insertion(+) > >> > >> I can confirm that this is indeed the same person. > > > > What would be more of interest is why we'd be interested in this patch > > as there is no commit/patch sent by Brandon with this email in gits history. > > Once I "git am" the message that began this thread, there will be a > commit under this new ident, so that would be somewhat a moot point. > > If this were "Jonathan asked Brandon if we want to record an address > we can reach him in our .mailmap file and sent a patch to add one", > then the story is different, and I tend to agree with you that such > a patch is more or less pointless. That's not the purpose of the > mailmap file. > Turns out this is exactly the reason :) I've had a couple of people reach out to me asking me to do this because CCing my old email bounces and they've wanted my input/comments on something related to work I've done. If that's not the intended purpose then please ignore this patch > Not until git-send-email learns to use that file to rewrite > To/cc/etc to the "canonical" addresses, anyway ;-) > > I am not sure if there are people whose "canonical" address to be > used as the author is not necessarily the best address they want to > get their e-mails at, though. If we can be reasonably sure that the > set of such people is empty, then people can take the above mention > about send-email as a hint about a low-hanging fruit ;-) > > Thanks. > > ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] mailmap: update brandon williams's email address 2018-12-08 6:51 ` Brandon Williams @ 2018-12-10 8:36 ` Johannes Schindelin 0 siblings, 0 replies; 12+ messages in thread From: Johannes Schindelin @ 2018-12-10 8:36 UTC (permalink / raw) To: Brandon Williams; +Cc: gitster, sbeller, jrnieder, git Hi, On Fri, 7 Dec 2018, Brandon Williams wrote: > On Fri, Dec 7, 2018 at 10:08 PM Junio C Hamano <gitster@pobox.com> > wrote: > > > > Stefan Beller <sbeller@google.com> writes: > > > > > On Fri, Dec 7, 2018 at 1:40 PM Jonathan Nieder <jrnieder@gmail.com> > > > wrote: > > >> > > >> Brandon Williams wrote: > > >> > > >> > Signed-off-by: Brandon Williams <bwilliams.eng@gmail.com> > > >> > --- > > >> > .mailmap | 1 + > > >> > 1 file changed, 1 insertion(+) > > >> > > >> I can confirm that this is indeed the same person. > > > > > > What would be more of interest is why we'd be interested in this > > > patch as there is no commit/patch sent by Brandon with this email in > > > gits history. > > > > Once I "git am" the message that began this thread, there will be a > > commit under this new ident, so that would be somewhat a moot point. > > > > If this were "Jonathan asked Brandon if we want to record an address > > we can reach him in our .mailmap file and sent a patch to add one", > > then the story is different, and I tend to agree with you that such a > > patch is more or less pointless. That's not the purpose of the > > mailmap file. > > > > Turns out this is exactly the reason :) I've had a couple of people > reach out to me asking me to do this because CCing my old email bounces > and they've wanted my input/comments on something related to work I've > done. If that's not the intended purpose then please ignore this patch Unless we come up with a better way to indicate the current address of a Git contributor (I seem to remember that David Turner used the same approach after leaving Twitter so that people could Cc: him with the correct address), I suggest that we keep using .mailmap for that purpose. Thanks, Dscho ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] mailmap: update brandon williams's email address 2018-12-08 6:08 ` Junio C Hamano 2018-12-08 6:51 ` Brandon Williams @ 2018-12-08 8:25 ` Duy Nguyen 2018-12-08 12:18 ` Ævar Arnfjörð Bjarmason 2 siblings, 0 replies; 12+ messages in thread From: Duy Nguyen @ 2018-12-08 8:25 UTC (permalink / raw) To: Junio C Hamano Cc: Stefan Beller, Jonathan Nieder, bwilliamseng, Git Mailing List, Brandon Williams On Sat, Dec 8, 2018 at 7:09 AM Junio C Hamano <gitster@pobox.com> wrote: > If this were "Jonathan asked Brandon if we want to record an address > we can reach him in our .mailmap file and sent a patch to add one", Not sure about Jonathan, but I did. > then the story is different, and I tend to agree with you that such > a patch is more or less pointless. That's not the purpose of the > mailmap file. Not directly, but when multiple commands use mailmap to show the canonical mail addresses, then it kinda is. When I look back at an old commit message, I may look up the author name and address, which is mapped. > Not until git-send-email learns to use that file to rewrite > To/cc/etc to the "canonical" addresses, anyway ;-) git-send-email does not have to when I copy/paste the address from git-log anyway. > I am not sure if there are people whose "canonical" address to be > used as the author is not necessarily the best address they want to > get their e-mails at, though. If we can be reasonably sure that the > set of such people is empty, then people can take the above mention > about send-email as a hint about a low-hanging fruit ;-) > > Thanks. > > -- Duy ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] mailmap: update brandon williams's email address 2018-12-08 6:08 ` Junio C Hamano 2018-12-08 6:51 ` Brandon Williams 2018-12-08 8:25 ` Duy Nguyen @ 2018-12-08 12:18 ` Ævar Arnfjörð Bjarmason 2 siblings, 0 replies; 12+ messages in thread From: Ævar Arnfjörð Bjarmason @ 2018-12-08 12:18 UTC (permalink / raw) To: Junio C Hamano Cc: Stefan Beller, Jonathan Nieder, bwilliamseng, git, bwilliams.eng On Sat, Dec 08 2018, Junio C Hamano wrote: > Stefan Beller <sbeller@google.com> writes: > >> On Fri, Dec 7, 2018 at 1:40 PM Jonathan Nieder <jrnieder@gmail.com> wrote: >>> >>> Brandon Williams wrote: >>> >>> > Signed-off-by: Brandon Williams <bwilliams.eng@gmail.com> >>> > --- >>> > .mailmap | 1 + >>> > 1 file changed, 1 insertion(+) >>> >>> I can confirm that this is indeed the same person. >> >> What would be more of interest is why we'd be interested in this patch >> as there is no commit/patch sent by Brandon with this email in gits history. > > Once I "git am" the message that began this thread, there will be a > commit under this new ident, so that would be somewhat a moot point. "Get to the top of 'git shortlog -sn' with this one easy trick" :) (The patch makes sense, good to see you back on-list Brandon) ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2019-01-18 18:38 UTC | newest] Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-12-07 20:56 [PATCH] mailmap: update brandon williams's email address Brandon Williams 2018-12-07 21:40 ` Jonathan Nieder 2018-12-07 22:11 ` Stefan Beller 2018-12-07 22:22 ` Jonathan Nieder 2019-01-18 16:57 ` Jeff King 2019-01-18 18:16 ` Junio C Hamano 2019-01-18 18:38 ` Jeff King 2018-12-08 6:08 ` Junio C Hamano 2018-12-08 6:51 ` Brandon Williams 2018-12-10 8:36 ` Johannes Schindelin 2018-12-08 8:25 ` Duy Nguyen 2018-12-08 12:18 ` Ævar Arnfjörð Bjarmason
Code repositories for project(s) associated with this public inbox https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).