From: Brandon Williams <bwilliamseng@gmail.com>
To: gitster@pobox.com
Cc: sbeller@google.com, jrnieder@gmail.com, git@vger.kernel.org
Subject: Re: [PATCH] mailmap: update brandon williams's email address
Date: Fri, 7 Dec 2018 22:51:57 -0800 [thread overview]
Message-ID: <CALN-EhSQZiOsXwOyDJo_muTcP9HsifmqyD1oLxMunv5CfAdHgg@mail.gmail.com> (raw)
In-Reply-To: <xmqq5zw48s9q.fsf@gitster-ct.c.googlers.com>
On Fri, Dec 7, 2018 at 10:08 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Stefan Beller <sbeller@google.com> writes:
>
> > On Fri, Dec 7, 2018 at 1:40 PM Jonathan Nieder <jrnieder@gmail.com> wrote:
> >>
> >> Brandon Williams wrote:
> >>
> >> > Signed-off-by: Brandon Williams <bwilliams.eng@gmail.com>
> >> > ---
> >> > .mailmap | 1 +
> >> > 1 file changed, 1 insertion(+)
> >>
> >> I can confirm that this is indeed the same person.
> >
> > What would be more of interest is why we'd be interested in this patch
> > as there is no commit/patch sent by Brandon with this email in gits history.
>
> Once I "git am" the message that began this thread, there will be a
> commit under this new ident, so that would be somewhat a moot point.
>
> If this were "Jonathan asked Brandon if we want to record an address
> we can reach him in our .mailmap file and sent a patch to add one",
> then the story is different, and I tend to agree with you that such
> a patch is more or less pointless. That's not the purpose of the
> mailmap file.
>
Turns out this is exactly the reason :) I've had a couple of people
reach out to me asking me to do this because CCing my old email
bounces and they've wanted my input/comments on something related to
work I've done. If that's not the intended purpose then please ignore
this patch
> Not until git-send-email learns to use that file to rewrite
> To/cc/etc to the "canonical" addresses, anyway ;-)
>
> I am not sure if there are people whose "canonical" address to be
> used as the author is not necessarily the best address they want to
> get their e-mails at, though. If we can be reasonably sure that the
> set of such people is empty, then people can take the above mention
> about send-email as a hint about a low-hanging fruit ;-)
>
> Thanks.
>
>
next prev parent reply other threads:[~2018-12-08 6:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 20:56 [PATCH] mailmap: update brandon williams's email address Brandon Williams
2018-12-07 21:40 ` Jonathan Nieder
2018-12-07 22:11 ` Stefan Beller
2018-12-07 22:22 ` Jonathan Nieder
2019-01-18 16:57 ` Jeff King
2019-01-18 18:16 ` Junio C Hamano
2019-01-18 18:38 ` Jeff King
2018-12-08 6:08 ` Junio C Hamano
2018-12-08 6:51 ` Brandon Williams [this message]
2018-12-10 8:36 ` Johannes Schindelin
2018-12-08 8:25 ` Duy Nguyen
2018-12-08 12:18 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALN-EhSQZiOsXwOyDJo_muTcP9HsifmqyD1oLxMunv5CfAdHgg@mail.gmail.com \
--to=bwilliamseng@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).