From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <johannes.schindelin@gmx.de>
Cc: git@vger.kernel.org, "Jeff King" <peff@peff.net>,
"Sverre Rabbelier" <srabbelier@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Matthieu Moy" <Matthieu.Moy@grenoble-inp.fr>
Subject: Re: [PATCH v4] t/Makefile: add a rule to re-run previously-failed tests
Date: Fri, 27 Jan 2017 10:53:18 -0800 [thread overview]
Message-ID: <xmqq4m0kz65d.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <0563f07117e828c072ba542c1a57441e2e8efb81.1485537593.git.johannes.schindelin@gmx.de> (Johannes Schindelin's message of "Fri, 27 Jan 2017 18:21:30 +0100 (CET)")
Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> This patch automates the process of determining which tests failed
> previously and re-running them.
> ...
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
I stored both versions in files and compared them, and it seems the
single word change in the proposed commit log message is the only
difference. I would have written "Automate the process...", though.
If you are resending, touching up to cover all points raised by a
reviewer and doing nothing else, having "Reviewed-by: Jeff King
<peff@peff.net>" would have been nicer.
Will queue. Thanks.
> ---
> Published-As: https://github.com/dscho/git/releases/tag/failing-tests-v4
> Fetch-It-Via: git fetch https://github.com/dscho/git failing-tests-v4
>
> t/Makefile | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/t/Makefile b/t/Makefile
> index d613935f14..1bb06c36f2 100644
> --- a/t/Makefile
> +++ b/t/Makefile
> @@ -35,6 +35,12 @@ all: $(DEFAULT_TEST_TARGET)
> test: pre-clean $(TEST_LINT)
> $(MAKE) aggregate-results-and-cleanup
>
> +failed:
> + @failed=$$(cd '$(TEST_RESULTS_DIRECTORY_SQ)' && \
> + grep -l '^failed [1-9]' *.counts | \
> + sed -n 's/\.counts$$/.sh/p') && \
> + test -z "$$failed" || $(MAKE) $$failed
> +
> prove: pre-clean $(TEST_LINT)
> @echo "*** prove ***"; $(PROVE) --exec '$(SHELL_PATH_SQ)' $(GIT_PROVE_OPTS) $(T) :: $(GIT_TEST_OPTS)
> $(MAKE) clean-except-prove-cache
>
> base-commit: 4e59582ff70d299f5a88449891e78d15b4b3fabe
next prev parent reply other threads:[~2017-01-27 18:57 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 7:02 [PATCH] t/Makefile: add a rule to re-run previously-failed tests Johannes Schindelin
2016-06-29 17:18 ` Junio C Hamano
2016-07-01 13:57 ` Johannes Schindelin
2016-06-30 6:37 ` Jeff King
2016-07-01 14:00 ` Johannes Schindelin
2016-08-29 13:46 ` [PATCH v2] " Johannes Schindelin
2016-08-30 8:43 ` Jeff King
2016-08-30 19:15 ` Junio C Hamano
2016-08-31 10:36 ` Johannes Schindelin
2016-09-01 3:59 ` Sverre Rabbelier
2016-09-01 8:27 ` Johannes Schindelin
2016-09-01 16:57 ` Sverre Rabbelier
2016-09-01 22:52 ` Junio C Hamano
2016-09-02 7:35 ` Johannes Schindelin
2016-09-08 20:34 ` Junio C Hamano
2016-08-30 20:48 ` Ævar Arnfjörð Bjarmason
2016-08-30 20:51 ` Jeff King
2016-08-30 20:58 ` Ævar Arnfjörð Bjarmason
2016-08-31 10:29 ` Johannes Schindelin
2016-08-31 13:42 ` Ævar Arnfjörð Bjarmason
2016-08-31 15:05 ` Johannes Schindelin
2016-09-02 10:25 ` Ævar Arnfjörð Bjarmason
2016-09-02 12:08 ` Johannes Schindelin
2016-09-02 16:36 ` Matthieu Moy
2016-09-04 7:55 ` Johannes Schindelin
2016-09-04 9:19 ` Matthieu Moy
2017-01-27 14:17 ` [PATCH v3] " Johannes Schindelin
2017-01-27 17:07 ` Jeff King
2017-01-27 17:21 ` Johannes Schindelin
2017-01-27 17:21 ` [PATCH v4] " Johannes Schindelin
2017-01-27 18:53 ` Junio C Hamano [this message]
2017-01-30 15:35 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4m0kz65d.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
--cc=peff@peff.net \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).