From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Sverre Rabbelier <srabbelier@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
git@vger.kernel.org
Subject: Re: [PATCH v2] t/Makefile: add a rule to re-run previously-failed tests
Date: Wed, 31 Aug 2016 12:36:05 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1608311233440.129229@virtualbox> (raw)
In-Reply-To: <xmqq37lm3w6u.fsf@gitster.mtv.corp.google.com>
Hi,
[Sverre: we are considering to remove the -<pid> suffix in test-results/,
see more below.]
On Tue, 30 Aug 2016, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > Hmm, interesting. Your approach seems reasonable, but I have to wonder
> > if writing the pid in the first place is sane.
> >
> > I started to write up my reasoning in this email, but realized it was
> > rapidly becoming the content of a commit message. So here is that
> > commit.
>
> Sounds sensible; if this makes Dscho's "which ones failed in the
> previous run" simpler, that is even better ;-)
I did not have the time to dig further before now. There must have been a
good reason why we append the PID.
Sverre, you added that code in 2d84e9f (Modify test-lib.sh to output stats
to t/test-results/*, 2008-06-08): any idea why the -<pid> suffix was
needed?
Ciao,
Dscho
next prev parent reply other threads:[~2016-08-31 10:38 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 7:02 [PATCH] t/Makefile: add a rule to re-run previously-failed tests Johannes Schindelin
2016-06-29 17:18 ` Junio C Hamano
2016-07-01 13:57 ` Johannes Schindelin
2016-06-30 6:37 ` Jeff King
2016-07-01 14:00 ` Johannes Schindelin
2016-08-29 13:46 ` [PATCH v2] " Johannes Schindelin
2016-08-30 8:43 ` Jeff King
2016-08-30 19:15 ` Junio C Hamano
2016-08-31 10:36 ` Johannes Schindelin [this message]
2016-09-01 3:59 ` Sverre Rabbelier
2016-09-01 8:27 ` Johannes Schindelin
2016-09-01 16:57 ` Sverre Rabbelier
2016-09-01 22:52 ` Junio C Hamano
2016-09-02 7:35 ` Johannes Schindelin
2016-09-08 20:34 ` Junio C Hamano
2016-08-30 20:48 ` Ævar Arnfjörð Bjarmason
2016-08-30 20:51 ` Jeff King
2016-08-30 20:58 ` Ævar Arnfjörð Bjarmason
2016-08-31 10:29 ` Johannes Schindelin
2016-08-31 13:42 ` Ævar Arnfjörð Bjarmason
2016-08-31 15:05 ` Johannes Schindelin
2016-09-02 10:25 ` Ævar Arnfjörð Bjarmason
2016-09-02 12:08 ` Johannes Schindelin
2016-09-02 16:36 ` Matthieu Moy
2016-09-04 7:55 ` Johannes Schindelin
2016-09-04 9:19 ` Matthieu Moy
2017-01-27 14:17 ` [PATCH v3] " Johannes Schindelin
2017-01-27 17:07 ` Jeff King
2017-01-27 17:21 ` Johannes Schindelin
2017-01-27 17:21 ` [PATCH v4] " Johannes Schindelin
2017-01-27 18:53 ` Junio C Hamano
2017-01-30 15:35 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1608311233440.129229@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).