From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] t/Makefile: add a rule to re-run previously-failed tests
Date: Fri, 1 Jul 2016 15:57:42 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1607011551550.12947@virtualbox> (raw)
In-Reply-To: <xmqqy45n52xp.fsf@gitster.mtv.corp.google.com>
Hi Junio,
On Wed, 29 Jun 2016, Junio C Hamano wrote:
> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
>
> > While developing patch series, it is a good practice to run the test
> > suite from time to time, just to make sure that obvious bugs are caught
> > early. With complex patch series, it is common to run `make -j15 -k
> > test`, i.e. run the tests in parallel and not stop at the first failing
> > test but continue.
>
> Hmmm, my tests run in parallel and do not stop at the first one
> without '-k'. What are we doing differently?
Probably none of your tests are failing... When I run tests with -j15 and
without -k, as soon as *any* test fails, the other 14 jobs stop after
running their respective current tests.
This is particularly annoying when some early test fails and a subsequent
test run reveals that *also* one of those pesky SVN tests failed.
> > It is the most convenient way to determine which tests failed after
> > running the entire test suite, in parallel, to look for left-over "trash
> > directory.t*" subdirectories in the t/ subdirectory.
>
> Good idea, but I'd drop "in the t/ subdirectory" from the
> description.
Okay.
> > +failed: $(patsubst trash,,$(patsubst directory.%,%.sh,$(wildcard trash\ directory.t[0-9]*)))
> > +
>
> This would not work if you use --root=<there> in GIT_TEST_OPTS, I am
> afraid.
Bah. You're correct. Would it be okay with you if I simply punted, like
this:
ifeq (,$(findstring --root,$(GIT_TEST_OPTS)))
failed: ...
else
failed:
echo "Sorry, the 'failed' rule is incompatible with --root=..." >&2
endif
? I really do not have time to spend more time on this right now...
Ciao,
Dscho
next prev parent reply other threads:[~2016-07-01 13:57 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 7:02 [PATCH] t/Makefile: add a rule to re-run previously-failed tests Johannes Schindelin
2016-06-29 17:18 ` Junio C Hamano
2016-07-01 13:57 ` Johannes Schindelin [this message]
2016-06-30 6:37 ` Jeff King
2016-07-01 14:00 ` Johannes Schindelin
2016-08-29 13:46 ` [PATCH v2] " Johannes Schindelin
2016-08-30 8:43 ` Jeff King
2016-08-30 19:15 ` Junio C Hamano
2016-08-31 10:36 ` Johannes Schindelin
2016-09-01 3:59 ` Sverre Rabbelier
2016-09-01 8:27 ` Johannes Schindelin
2016-09-01 16:57 ` Sverre Rabbelier
2016-09-01 22:52 ` Junio C Hamano
2016-09-02 7:35 ` Johannes Schindelin
2016-09-08 20:34 ` Junio C Hamano
2016-08-30 20:48 ` Ævar Arnfjörð Bjarmason
2016-08-30 20:51 ` Jeff King
2016-08-30 20:58 ` Ævar Arnfjörð Bjarmason
2016-08-31 10:29 ` Johannes Schindelin
2016-08-31 13:42 ` Ævar Arnfjörð Bjarmason
2016-08-31 15:05 ` Johannes Schindelin
2016-09-02 10:25 ` Ævar Arnfjörð Bjarmason
2016-09-02 12:08 ` Johannes Schindelin
2016-09-02 16:36 ` Matthieu Moy
2016-09-04 7:55 ` Johannes Schindelin
2016-09-04 9:19 ` Matthieu Moy
2017-01-27 14:17 ` [PATCH v3] " Johannes Schindelin
2017-01-27 17:07 ` Jeff King
2017-01-27 17:21 ` Johannes Schindelin
2017-01-27 17:21 ` [PATCH v4] " Johannes Schindelin
2017-01-27 18:53 ` Junio C Hamano
2017-01-30 15:35 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1607011551550.12947@virtualbox \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).