From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: git@vger.kernel.org, christian.couder@gmail.com
Subject: Re: [PATCH v2 03/10] ref-filter: support printing N lines from tag annotation
Date: Thu, 09 Jul 2015 15:07:09 +0200 [thread overview]
Message-ID: <vpqpp417a4i.fsf@anie.imag.fr> (raw)
In-Reply-To: <1436437671-25600-3-git-send-email-karthik.188@gmail.com> (Karthik Nayak's message of "Thu, 9 Jul 2015 15:57:44 +0530")
Karthik Nayak <karthik.188@gmail.com> writes:
> In 'tag.c' we can print N lines from the annotation of the tag
> using the '-n<num>' option.
Not only annotation of the tag, but also from the commit message for
lightweight tags.
> --- a/builtin/tag.c
> +++ b/builtin/tag.c
> @@ -185,6 +185,10 @@ static enum contains_result contains(struct commit *candidate,
> return contains_test(candidate, want);
> }
>
> +/*
> + * Currently dupplicated in ref-filter, will eventually be removed as
dupplicated -> duplicated.
> --- a/ref-filter.h
> +++ b/ref-filter.h
> @@ -55,6 +55,7 @@ struct ref_filter {
> struct commit *merge_commit;
>
> unsigned int with_commit_tag_algo : 1;
> + unsigned int lines;
> };
>
> struct ref_filter_cbdata {
> @@ -87,7 +88,7 @@ int verify_ref_format(const char *format);
> /* Sort the given ref_array as per the ref_sorting provided */
> void ref_array_sort(struct ref_sorting *sort, struct ref_array *array);
> /* Print the ref using the given format and quote_style */
> -void show_ref_array_item(struct ref_array_item *info, const char *format, int quote_style);
> +void show_ref_array_item(struct ref_array_item *info, const char *format, int quote_style, unsigned int lines);
I would add "If lines > 0, prints the first 'lines' no of lines of the
object pointed to" or so to the docstring.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2015-07-09 13:07 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 10:27 [PATCH v2 00/10] Port tag.c to use ref-filter APIs Karthik Nayak
2015-07-09 10:27 ` [PATCH v2 01/10] ref-filter: add %(refname:shortalign=X) option Karthik Nayak
2015-07-09 10:27 ` [PATCH v2 02/10] ref-filter: add option to filter only tags Karthik Nayak
2015-07-09 10:27 ` [PATCH v2 03/10] ref-filter: support printing N lines from tag annotation Karthik Nayak
2015-07-09 13:07 ` Matthieu Moy [this message]
2015-07-10 10:38 ` Karthik Nayak
2015-07-09 10:27 ` [PATCH v2 04/10] ref-filter: add support to sort by version Karthik Nayak
2015-07-09 13:29 ` Matthieu Moy
2015-07-10 10:52 ` Karthik Nayak
2015-07-10 11:01 ` Karthik Nayak
2015-07-10 12:18 ` Matthieu Moy
2015-07-11 5:54 ` Karthik Nayak
2015-07-09 10:27 ` [PATCH v2 05/10] ref-filter: add option to match literal pattern Karthik Nayak
2015-07-09 13:32 ` Matthieu Moy
2015-07-10 11:11 ` Karthik Nayak
2015-07-10 16:43 ` Junio C Hamano
2015-07-11 5:55 ` Karthik Nayak
2015-07-11 9:26 ` Matthieu Moy
2015-07-11 12:54 ` Karthik Nayak
2015-07-09 10:27 ` [PATCH v2 06/10] Documentation/tag: remove double occurance of "<pattern>" Karthik Nayak
2015-07-09 12:19 ` Christian Couder
2015-07-09 12:56 ` Karthik Nayak
2015-07-10 16:44 ` Junio C Hamano
2015-07-12 12:39 ` Karthik Nayak
2015-07-09 10:27 ` [PATCH v2 07/10] tag.c: use 'ref-filter' data structures Karthik Nayak
2015-07-09 10:55 ` [PATCH v2 08/10] tag.c: use 'ref-filter' APIs Karthik Nayak
2015-07-09 12:48 ` Matthieu Moy
2015-07-09 12:55 ` Karthik Nayak
2015-07-09 13:43 ` Matthieu Moy
2015-07-10 9:41 ` Karthik Nayak
2015-07-09 13:41 ` Matthieu Moy
2015-07-09 10:58 ` Karthik Nayak
2015-07-12 9:45 ` Duy Nguyen
2015-07-12 19:36 ` Karthik Nayak
2015-07-13 10:46 ` Duy Nguyen
2015-07-13 20:34 ` Karthik Nayak
2015-07-09 10:59 ` [PATCH v2 09/10] tag.c: implement '--format' option Karthik Nayak
2015-07-09 11:00 ` [PATCH v2 10/10] tag.c: implement '--merged' and '--no-merged' options Karthik Nayak
2015-07-09 12:58 ` [PATCH v2 01/10] ref-filter: add %(refname:shortalign=X) option Matthieu Moy
2015-07-11 6:07 ` Karthik Nayak
2015-07-11 10:20 ` Matthieu Moy
2015-07-10 16:20 ` Junio C Hamano
2015-07-11 12:05 ` Karthik Nayak
2015-07-12 1:47 ` Duy Nguyen
2015-07-12 8:59 ` Duy Nguyen
2015-07-12 19:56 ` Karthik Nayak
2015-07-13 10:51 ` Duy Nguyen
2015-07-13 20:36 ` Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqpp417a4i.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).