From: Karthik Nayak <karthik.188@gmail.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, Git <git@vger.kernel.org>,
Christian Couder <christian.couder@gmail.com>,
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
Michael Haggerty <mhagger@alum.mit.edu>
Subject: Re: [PATCH v2 01/10] ref-filter: add %(refname:shortalign=X) option
Date: Tue, 14 Jul 2015 02:06:15 +0530 [thread overview]
Message-ID: <CAOLa=ZRuCa=7QzS7K86eikApiGgYsGLeaP0mw5Ax=k5en72jxA@mail.gmail.com> (raw)
In-Reply-To: <CACsJy8D6XOJbVb9LiDmmNuH9UWmyj9BRc0V5GYq-0wwi2uvN0w@mail.gmail.com>
On Mon, Jul 13, 2015 at 4:21 PM, Duy Nguyen <pclouds@gmail.com> wrote:
> On Mon, Jul 13, 2015 at 2:56 AM, Karthik Nayak <karthik.188@gmail.com> wrote:
>> On Sun, Jul 12, 2015 at 7:17 AM, Duy Nguyen <pclouds@gmail.com> wrote:
>>>
>>> I guess if you can have multiple arguments after ':' in an atom, then
>>> you have wiggle room for future. But it looks like you only accept one
>>> argument after ':'.. (I only checked the version on 'pu'). Having an
>>> "alignment atom" to augment the real one (like %< changes the behavior
>>> of the next placeholder), could also work, but it adds dependency
>>> between atoms, something I don't think ref-filter.c is ready for.
>>>
>>
>> I was thinking of something on the lines of having a function which right
>> before printing checks if any "align" option is given to the end of a given
>> item and aligns it accordingly, this ensures that any item which needs to
>> have such an option can easily do so.
>>
>> https://github.com/KarthikNayak/git/commit/0284320483d6442a6425fc665e740f9f975654a1
>>
>> This is what I came up with, you could have a look and let me know if
>> you have any
>> suggestions.
>
> Yeah, pretty close to what I described in the other mail. Now if you
> make "align" a separate atom, I think it would reduce clutter in
> populate_value() (my personal opinion is this function looks too messy
> already) and we can easily add more alignment options in future :)
> --
> Duy
Yeah, that seems like the way to go, eventually :)
--
Regards,
Karthik Nayak
prev parent reply other threads:[~2015-07-13 20:36 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 10:27 [PATCH v2 00/10] Port tag.c to use ref-filter APIs Karthik Nayak
2015-07-09 10:27 ` [PATCH v2 01/10] ref-filter: add %(refname:shortalign=X) option Karthik Nayak
2015-07-09 10:27 ` [PATCH v2 02/10] ref-filter: add option to filter only tags Karthik Nayak
2015-07-09 10:27 ` [PATCH v2 03/10] ref-filter: support printing N lines from tag annotation Karthik Nayak
2015-07-09 13:07 ` Matthieu Moy
2015-07-10 10:38 ` Karthik Nayak
2015-07-09 10:27 ` [PATCH v2 04/10] ref-filter: add support to sort by version Karthik Nayak
2015-07-09 13:29 ` Matthieu Moy
2015-07-10 10:52 ` Karthik Nayak
2015-07-10 11:01 ` Karthik Nayak
2015-07-10 12:18 ` Matthieu Moy
2015-07-11 5:54 ` Karthik Nayak
2015-07-09 10:27 ` [PATCH v2 05/10] ref-filter: add option to match literal pattern Karthik Nayak
2015-07-09 13:32 ` Matthieu Moy
2015-07-10 11:11 ` Karthik Nayak
2015-07-10 16:43 ` Junio C Hamano
2015-07-11 5:55 ` Karthik Nayak
2015-07-11 9:26 ` Matthieu Moy
2015-07-11 12:54 ` Karthik Nayak
2015-07-09 10:27 ` [PATCH v2 06/10] Documentation/tag: remove double occurance of "<pattern>" Karthik Nayak
2015-07-09 12:19 ` Christian Couder
2015-07-09 12:56 ` Karthik Nayak
2015-07-10 16:44 ` Junio C Hamano
2015-07-12 12:39 ` Karthik Nayak
2015-07-09 10:27 ` [PATCH v2 07/10] tag.c: use 'ref-filter' data structures Karthik Nayak
2015-07-09 10:55 ` [PATCH v2 08/10] tag.c: use 'ref-filter' APIs Karthik Nayak
2015-07-09 12:48 ` Matthieu Moy
2015-07-09 12:55 ` Karthik Nayak
2015-07-09 13:43 ` Matthieu Moy
2015-07-10 9:41 ` Karthik Nayak
2015-07-09 13:41 ` Matthieu Moy
2015-07-09 10:58 ` Karthik Nayak
2015-07-12 9:45 ` Duy Nguyen
2015-07-12 19:36 ` Karthik Nayak
2015-07-13 10:46 ` Duy Nguyen
2015-07-13 20:34 ` Karthik Nayak
2015-07-09 10:59 ` [PATCH v2 09/10] tag.c: implement '--format' option Karthik Nayak
2015-07-09 11:00 ` [PATCH v2 10/10] tag.c: implement '--merged' and '--no-merged' options Karthik Nayak
2015-07-09 12:58 ` [PATCH v2 01/10] ref-filter: add %(refname:shortalign=X) option Matthieu Moy
2015-07-11 6:07 ` Karthik Nayak
2015-07-11 10:20 ` Matthieu Moy
2015-07-10 16:20 ` Junio C Hamano
2015-07-11 12:05 ` Karthik Nayak
2015-07-12 1:47 ` Duy Nguyen
2015-07-12 8:59 ` Duy Nguyen
2015-07-12 19:56 ` Karthik Nayak
2015-07-13 10:51 ` Duy Nguyen
2015-07-13 20:36 ` Karthik Nayak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOLa=ZRuCa=7QzS7K86eikApiGgYsGLeaP0mw5Ax=k5en72jxA@mail.gmail.com' \
--to=karthik.188@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mhagger@alum.mit.edu \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).