From: Duy Nguyen <pclouds@gmail.com>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Christian Couder <christian.couder@gmail.com>,
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Subject: Re: [PATCH v2 08/10] tag.c: use 'ref-filter' APIs
Date: Mon, 13 Jul 2015 17:46:11 +0700 [thread overview]
Message-ID: <CACsJy8DRYGSoiyPRi3hCD54NA1TF2mr5+9xwReX333ppdoAg+A@mail.gmail.com> (raw)
In-Reply-To: <CAOLa=ZSR+QPnE36F=kX5w7q_ANobso+MM2q9-SKBARYghoJvrA@mail.gmail.com>
On Mon, Jul 13, 2015 at 2:36 AM, Karthik Nayak <karthik.188@gmail.com> wrote:
> What I was thinking of was getting rid of the whole "align" feature where
> you provide a value to which it would align.
>
> Something like: --format="%(item:modifieralign)" which would use something
> on the lines of what the max-width calculator in branch -l uses, to get the max
> alignment size. But the problem is that ref-filter goes through the refs using
> a function which has no connections with the atoms used. So a more practical
> solution would be --format="%(item:modifieralign=X)" where we could provide a
> means of calculating X via ref-filter. Something like this in tag.c:
>
> int max_width = get_max_width("<item to get max_width of>");
> use this max_width to then do a
> --format="%(item:modifieralign=X)", where X = max_width
>
> What do you think?
This is where separate "alignment atoms" (instead of alignment
modifiers) make sense. Suppose you introduce another function, let's
say print_all() for now, to wrap the "for (i < maxcount)" loop at the
end of for-each-ref, you would have total control over display and
formatting. populate_value() generates empty strings for these
alignment atoms (because they don't really have true values). Those
alignment atoms are recognized in print_all() and
show_ref_array_item(). In print_all(), if it sees max width needs to
be calculated (because the user does not specify the width), it can
call populate_value() for an atom for all rows. show_ref_array_item()
does the padding and even truncating if needed. This pattern is
similar to how print_columns() works, first we collect data of the
whole "table", then we place them line by line.
It sounds good to me. But it may not be the best option, I don't know.
And it may create unnecessary work. So you and your mentors decide.
--
Duy
next prev parent reply other threads:[~2015-07-13 10:46 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 10:27 [PATCH v2 00/10] Port tag.c to use ref-filter APIs Karthik Nayak
2015-07-09 10:27 ` [PATCH v2 01/10] ref-filter: add %(refname:shortalign=X) option Karthik Nayak
2015-07-09 10:27 ` [PATCH v2 02/10] ref-filter: add option to filter only tags Karthik Nayak
2015-07-09 10:27 ` [PATCH v2 03/10] ref-filter: support printing N lines from tag annotation Karthik Nayak
2015-07-09 13:07 ` Matthieu Moy
2015-07-10 10:38 ` Karthik Nayak
2015-07-09 10:27 ` [PATCH v2 04/10] ref-filter: add support to sort by version Karthik Nayak
2015-07-09 13:29 ` Matthieu Moy
2015-07-10 10:52 ` Karthik Nayak
2015-07-10 11:01 ` Karthik Nayak
2015-07-10 12:18 ` Matthieu Moy
2015-07-11 5:54 ` Karthik Nayak
2015-07-09 10:27 ` [PATCH v2 05/10] ref-filter: add option to match literal pattern Karthik Nayak
2015-07-09 13:32 ` Matthieu Moy
2015-07-10 11:11 ` Karthik Nayak
2015-07-10 16:43 ` Junio C Hamano
2015-07-11 5:55 ` Karthik Nayak
2015-07-11 9:26 ` Matthieu Moy
2015-07-11 12:54 ` Karthik Nayak
2015-07-09 10:27 ` [PATCH v2 06/10] Documentation/tag: remove double occurance of "<pattern>" Karthik Nayak
2015-07-09 12:19 ` Christian Couder
2015-07-09 12:56 ` Karthik Nayak
2015-07-10 16:44 ` Junio C Hamano
2015-07-12 12:39 ` Karthik Nayak
2015-07-09 10:27 ` [PATCH v2 07/10] tag.c: use 'ref-filter' data structures Karthik Nayak
2015-07-09 10:55 ` [PATCH v2 08/10] tag.c: use 'ref-filter' APIs Karthik Nayak
2015-07-09 12:48 ` Matthieu Moy
2015-07-09 12:55 ` Karthik Nayak
2015-07-09 13:43 ` Matthieu Moy
2015-07-10 9:41 ` Karthik Nayak
2015-07-09 13:41 ` Matthieu Moy
2015-07-09 10:58 ` Karthik Nayak
2015-07-12 9:45 ` Duy Nguyen
2015-07-12 19:36 ` Karthik Nayak
2015-07-13 10:46 ` Duy Nguyen [this message]
2015-07-13 20:34 ` Karthik Nayak
2015-07-09 10:59 ` [PATCH v2 09/10] tag.c: implement '--format' option Karthik Nayak
2015-07-09 11:00 ` [PATCH v2 10/10] tag.c: implement '--merged' and '--no-merged' options Karthik Nayak
2015-07-09 12:58 ` [PATCH v2 01/10] ref-filter: add %(refname:shortalign=X) option Matthieu Moy
2015-07-11 6:07 ` Karthik Nayak
2015-07-11 10:20 ` Matthieu Moy
2015-07-10 16:20 ` Junio C Hamano
2015-07-11 12:05 ` Karthik Nayak
2015-07-12 1:47 ` Duy Nguyen
2015-07-12 8:59 ` Duy Nguyen
2015-07-12 19:56 ` Karthik Nayak
2015-07-13 10:51 ` Duy Nguyen
2015-07-13 20:36 ` Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACsJy8DRYGSoiyPRi3hCD54NA1TF2mr5+9xwReX333ppdoAg+A@mail.gmail.com \
--to=pclouds@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).