From: "Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: "Derrick Stolee" <dstolee@microsoft.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Elijah Newren" <newren@gmail.com>,
"Elijah Newren" <newren@gmail.com>
Subject: [PATCH v3 0/3] repo-settings: fix checking for fetch.negotiationAlgorithm=default
Date: Tue, 01 Feb 2022 17:00:25 +0000 [thread overview]
Message-ID: <pull.1131.v3.git.1643734828.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.1131.v2.git.1643478692337.gitgitgadget@gmail.com>
This regression is not new in v2.35; it first appeared in v2.34. So, not
urgent.
Changes since v2:
* Also fix the fact that fetch.negotationAlgorithm=$BOGUS_VALUE no longer
errors out (yet another regression, this one dating back to v2.24.0), and
add a test to make sure we don't regress it again.
* Add 'consecutive' as a synonym for 'default', and remove 'default' from
the documentation to guide people towards using 'consecutive' when they
want the classic behavior.
Changes since v1:
* Put the common code in two testcases into a function, and then just
invoked it from each
Elijah Newren (3):
repo-settings: fix checking for fetch.negotiationAlgorithm=default
repo-settings: fix error handling for unknown values
repo-settings: name the default fetch.negotiationAlgorithm
'consecutive'
Documentation/config/fetch.txt | 21 ++++++++++-----------
fetch-negotiator.c | 2 +-
repo-settings.c | 7 ++++++-
repository.h | 2 +-
t/t5500-fetch-pack.sh | 24 +++++++++++++++++++++---
5 files changed, 39 insertions(+), 17 deletions(-)
base-commit: 89bece5c8c96f0b962cfc89e63f82d603fd60bed
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1131%2Fnewren%2Ffix-fetch-negotiation-algorithm-equals-default-v3
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1131/newren/fix-fetch-negotiation-algorithm-equals-default-v3
Pull-Request: https://github.com/gitgitgadget/git/pull/1131
Range-diff vs v2:
1: 633c873b513 ! 1: df0ec5ffe98 repo-settings: fix checking for fetch.negotiationAlgorithm=default
@@ t/t5500-fetch-pack.sh: test_expect_success 'use ref advertisement to prune "have
+test_expect_success 'same as last but with config overrides' '
+ test_negotiation_algorithm_default \
+ -c feature.experimental=true \
-+ -c fetch.negotiationAlgorithm=default \
++ -c fetch.negotiationAlgorithm=default
'
test_expect_success 'filtering by size' '
-: ----------- > 2: 23f692b81be repo-settings: fix error handling for unknown values
-: ----------- > 3: 7b28c527a90 repo-settings: name the default fetch.negotiationAlgorithm 'consecutive'
--
gitgitgadget
next prev parent reply other threads:[~2022-02-01 17:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 1:56 [PATCH] repo-settings: fix checking for fetch.negotiationAlgorithm=default Elijah Newren via GitGitGadget
2022-01-28 7:25 ` Ævar Arnfjörð Bjarmason
2022-01-29 1:40 ` Elijah Newren
2022-01-29 6:08 ` Ævar Arnfjörð Bjarmason
2022-01-31 16:57 ` Junio C Hamano
2022-01-31 17:33 ` Elijah Newren
2022-01-31 21:03 ` Ævar Arnfjörð Bjarmason
2022-01-31 21:47 ` Elijah Newren
2022-02-01 17:37 ` Jonathan Tan
2022-01-31 22:06 ` Junio C Hamano
2022-01-29 17:51 ` [PATCH v2] " Elijah Newren via GitGitGadget
2022-02-01 17:00 ` Elijah Newren via GitGitGadget [this message]
2022-02-01 17:00 ` [PATCH v3 1/3] " Elijah Newren via GitGitGadget
2022-02-01 18:21 ` Junio C Hamano
2022-02-01 17:00 ` [PATCH v3 2/3] repo-settings: fix error handling for unknown values Elijah Newren via GitGitGadget
2022-02-01 18:21 ` Junio C Hamano
2022-02-01 17:00 ` [PATCH v3 3/3] repo-settings: name the default fetch.negotiationAlgorithm 'consecutive' Elijah Newren via GitGitGadget
2022-02-01 18:35 ` Junio C Hamano
2022-02-02 3:42 ` [PATCH v4 0/3] repo-settings: fix checking for fetch.negotiationAlgorithm=default Elijah Newren via GitGitGadget
2022-02-02 3:42 ` [PATCH v4 1/3] " Elijah Newren via GitGitGadget
2022-02-02 3:42 ` [PATCH v4 2/3] repo-settings: fix error handling for unknown values Elijah Newren via GitGitGadget
2022-02-02 3:42 ` [PATCH v4 3/3] repo-settings: rename the traditional default fetch.negotiationAlgorithm Elijah Newren via GitGitGadget
2022-02-02 17:50 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.1131.v3.git.1643734828.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=avarab@gmail.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=newren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).