From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Elijah Newren via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Jonathan Nieder <jrnieder@gmail.com>,
Jonathan Tan <jonathantanmy@google.com>,
jabolopes@google.com, Jeff Hostetler <jeffhostetler@github.com>,
Elijah Newren <newren@gmail.com>,
Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH] Provide config option to expect files outside sparse patterns
Date: Mon, 21 Feb 2022 21:34:35 +0100 (CET) [thread overview]
Message-ID: <nycvar.QRO.7.76.6.2202212100080.4418@tvgsbejvaqbjf.bet> (raw)
In-Reply-To: <pull.1153.git.1645333542011.gitgitgadget@gmail.com>
Hi Elijah,
In addition to Stolee's feedback...
On Sun, 20 Feb 2022, Elijah Newren via GitGitGadget wrote:
> diff --git a/config.c b/config.c
> index 2bffa8d4a01..68e877a1d80 100644
> --- a/config.c
> +++ b/config.c
> @@ -1520,6 +1520,11 @@ static int git_default_core_config(const char *var, const char *value, void *cb)
> return 0;
> }
>
> + if (!strcmp(var, "core.expectfilesoutsidesparsepatterns")) {
> + core_expect_files_outside_sparse_patterns = git_config_bool(var, value);
> + return 0;
> + }
The `core` section is already quite crowded (for which I am partially
responsible, of course).
Maybe it would be a good idea to introduce the `sparse` section, using
`sparse.allowFilesMatchingPatterns` or `sparse.applyPatternsToWorktree =
false`?
Ciao,
Dscho
next prev parent reply other threads:[~2022-02-21 20:35 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-20 5:05 [PATCH] Provide config option to expect files outside sparse patterns Elijah Newren via GitGitGadget
2022-02-20 19:41 ` Derrick Stolee
2022-02-20 20:16 ` Junio C Hamano
2022-02-22 2:17 ` Elijah Newren
2022-02-22 12:28 ` Johannes Schindelin
2022-02-22 13:43 ` Derrick Stolee
2022-02-21 20:34 ` Johannes Schindelin [this message]
2022-02-21 22:53 ` Ævar Arnfjörð Bjarmason
2022-02-22 2:25 ` Elijah Newren
2022-02-22 12:13 ` Johannes Schindelin
2022-02-22 12:57 ` Ævar Arnfjörð Bjarmason
2022-02-22 23:13 ` Jonathan Nieder
2022-02-25 16:39 ` Ævar Arnfjörð Bjarmason
2022-02-22 2:23 ` Elijah Newren
2022-02-22 10:05 ` Ævar Arnfjörð Bjarmason
2022-02-22 12:11 ` Johannes Schindelin
2022-02-22 13:47 ` Derrick Stolee
2022-02-23 2:26 ` [PATCH v2] repo_read_index: add config " Jonathan Nieder
2022-02-23 3:10 ` Elijah Newren
2022-02-24 5:22 ` [PATCH v3] " Elijah Newren
2022-02-24 18:24 ` Junio C Hamano
2022-02-26 5:58 ` Elijah Newren
2022-02-25 16:33 ` Jonathan Nieder
2022-02-26 6:01 ` Elijah Newren
2022-02-26 6:12 ` [PATCH v4] " Elijah Newren
2022-03-02 4:33 ` [PATCH v5] " Elijah Newren
2022-03-02 7:36 ` Junio C Hamano
2022-03-02 8:01 ` Elijah Newren
2022-03-02 13:37 ` [PATCH v4] " Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.QRO.7.76.6.2202212100080.4418@tvgsbejvaqbjf.bet \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=jabolopes@google.com \
--cc=jeffhostetler@github.com \
--cc=jonathantanmy@google.com \
--cc=jrnieder@gmail.com \
--cc=newren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).