git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Elijah Newren <newren@gmail.com>,
	Elijah Newren via GitGitGadget <gitgitgadget@gmail.com>,
	Git Mailing List <git@vger.kernel.org>,
	Jonathan Nieder <jrnieder@gmail.com>,
	Jonathan Tan <jonathantanmy@google.com>,
	Jose Lopes <jabolopes@google.com>,
	Jeff Hostetler <jeffhostetler@github.com>
Subject: Re: [PATCH] Provide config option to expect files outside sparse patterns
Date: Tue, 22 Feb 2022 13:57:00 +0100	[thread overview]
Message-ID: <220222.8635kb832w.gmgdl@evledraar.gmail.com> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.2202221311480.11118@tvgsbejvaqbjf.bet>


On Tue, Feb 22 2022, Johannes Schindelin wrote:

> Hi Elijah,
>
> On Mon, 21 Feb 2022, Elijah Newren wrote:
>
>> On Mon, Feb 21, 2022 at 2:57 PM Ævar Arnfjörð Bjarmason
>> <avarab@gmail.com> wrote:
>>
>> > There's also no law that says we can't have a three-level variable as
>> > core.sparse.*, perhaps that would be the start of a good trend, and it
>> > would sort adjacent to core.sparse[A-Z].* ...
>>
>> Interesting thought.  I'm curious what others think of this.
>
> What would make it `core`?
>
> In other words, while it is valuable to consider this option, I don't
> think that it solves anything, for the price of additional complexity.

To a first approximation what makes it core.* is that we have a
core.sparseCheckout.

It's hard come up with some definition of config namespacing where it
belongs there, but not a setting that tweaks it further, no?

I.e. we could quibble with the benefit of hindsight whether
core.sshCommand was the best idea at the time, or if it should be
remote.sshCommand or whatever.

But if we introduced a more specific sshCommandSomething having it there
instead of ... well, damn, I forgot that we have ssh.variant :)

Anyway, as noted (and I feel I have to comment as the originator of this
thread) I think the bikeshedding about namespacing is less important
than making sure from a user perspective that these are discoverable.

E.g. core.sshCommand doesn't reference ssh.variant or the other way
around, and in my "man git-config" they're at ~25% and ~90% in to what's
now a *huge* document. You need to read the whole thing or have the
foresight to search through it to discover both.

So for core.sshCommand and ssh.variant, and core.sparse* and sparse.*
cross-linking etc. would go a long way...

Aside: I do have some local patches (waiting on a couple of other things
I have outstanding) to add a "CONFIGURATION" section to all of the
built-in commands with some including/splitting up of
Documentation/config**.txt, so "man git-sparse-checkout" would have a
section listing the subset of "git-config" applicable to the command.

  reply	other threads:[~2022-02-22 13:04 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-20  5:05 [PATCH] Provide config option to expect files outside sparse patterns Elijah Newren via GitGitGadget
2022-02-20 19:41 ` Derrick Stolee
2022-02-20 20:16   ` Junio C Hamano
2022-02-22  2:17   ` Elijah Newren
2022-02-22 12:28     ` Johannes Schindelin
2022-02-22 13:43       ` Derrick Stolee
2022-02-21 20:34 ` Johannes Schindelin
2022-02-21 22:53   ` Ævar Arnfjörð Bjarmason
2022-02-22  2:25     ` Elijah Newren
2022-02-22 12:13       ` Johannes Schindelin
2022-02-22 12:57         ` Ævar Arnfjörð Bjarmason [this message]
2022-02-22 23:13           ` Jonathan Nieder
2022-02-25 16:39             ` Ævar Arnfjörð Bjarmason
2022-02-22  2:23   ` Elijah Newren
2022-02-22 10:05     ` Ævar Arnfjörð Bjarmason
2022-02-22 12:11     ` Johannes Schindelin
2022-02-22 13:47     ` Derrick Stolee
2022-02-23  2:26 ` [PATCH v2] repo_read_index: add config " Jonathan Nieder
2022-02-23  3:10   ` Elijah Newren
2022-02-24  5:22   ` [PATCH v3] " Elijah Newren
2022-02-24 18:24     ` Junio C Hamano
2022-02-26  5:58       ` Elijah Newren
2022-02-25 16:33     ` Jonathan Nieder
2022-02-26  6:01       ` Elijah Newren
2022-02-26  6:12     ` [PATCH v4] " Elijah Newren
2022-03-02  4:33       ` [PATCH v5] " Elijah Newren
2022-03-02  7:36         ` Junio C Hamano
2022-03-02  8:01           ` Elijah Newren
2022-03-02 13:37       ` [PATCH v4] " Derrick Stolee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=220222.8635kb832w.gmgdl@evledraar.gmail.com \
    --to=avarab@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=jabolopes@google.com \
    --cc=jeffhostetler@github.com \
    --cc=jonathantanmy@google.com \
    --cc=jrnieder@gmail.com \
    --cc=newren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).