git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Derrick Stolee <derrickstolee@github.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Elijah Newren <newren@gmail.com>
Cc: Elijah Newren via GitGitGadget <gitgitgadget@gmail.com>,
	Git Mailing List <git@vger.kernel.org>,
	Jonathan Nieder <jrnieder@gmail.com>,
	Jonathan Tan <jonathantanmy@google.com>,
	Jose Lopes <jabolopes@google.com>,
	Jeff Hostetler <jeffhostetler@github.com>
Subject: Re: [PATCH] Provide config option to expect files outside sparse patterns
Date: Tue, 22 Feb 2022 08:43:19 -0500	[thread overview]
Message-ID: <f65462bf-eed7-f8b9-6255-249e5128172f@github.com> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.2202221313400.11118@tvgsbejvaqbjf.bet>

On 2/22/2022 7:28 AM, Johannes Schindelin wrote:
> Hi Elijah,
> 
> On Mon, 21 Feb 2022, Elijah Newren wrote:
> 
>> On Sun, Feb 20, 2022 at 11:41 AM Derrick Stolee
>> <derrickstolee@github.com> wrote:
>>
>>> The only concern here really is if we want to be picky about the "VFS
>>> for Git" references instead of "vfsd" references in the commit
>>> message.
>>
>> I'm not sure I'm understanding the distinction.  Was "VFS for Git"
>> renamed to "vfsd"?  Is "vfsd" Google's modified version?  Something
>> else?
> 
> VFS for Git is the existing project at
> https://github.com/microsoft/VFSforGit which is pretty much in maintenance
> mode.
> 
> vfsd was mentioned by Jonathan Tan in
> https://lore.kernel.org/git/20220207190320.2960362-1-jonathantanmy@google.com/.
> From what I gather, it is a completely separate implementation of the same
> ideas of VFS for Git, but from what I see it does not share any code with
> it (and it is unclear how much vfsd tries/tried to learn from VFS for Git,
> it looks like it's being done from scratch but that impression could be
> incorrect).

Elijah is correct that "vfsd" is not publicly visible outside of this
message, so that makes it difficult for us to verify that these patches
being made for it actually work as we intend.

> 	Side note: VFS for Git itself requires the Microsoft fork of Git
> 	to work, therefore this patch would only be needed in that fork,
> 	as far as VFS for Git is concerned.

I would drop this side note, since a big reason for the microsoft/git
fork is so we can create custom patches that handle these issues. We
would probably have created a similar patch during release integration,
but we are grateful to use this patch as a base for making these
integrations simpler in the future.

Thanks,
-Stolee

  reply	other threads:[~2022-02-22 13:43 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-20  5:05 [PATCH] Provide config option to expect files outside sparse patterns Elijah Newren via GitGitGadget
2022-02-20 19:41 ` Derrick Stolee
2022-02-20 20:16   ` Junio C Hamano
2022-02-22  2:17   ` Elijah Newren
2022-02-22 12:28     ` Johannes Schindelin
2022-02-22 13:43       ` Derrick Stolee [this message]
2022-02-21 20:34 ` Johannes Schindelin
2022-02-21 22:53   ` Ævar Arnfjörð Bjarmason
2022-02-22  2:25     ` Elijah Newren
2022-02-22 12:13       ` Johannes Schindelin
2022-02-22 12:57         ` Ævar Arnfjörð Bjarmason
2022-02-22 23:13           ` Jonathan Nieder
2022-02-25 16:39             ` Ævar Arnfjörð Bjarmason
2022-02-22  2:23   ` Elijah Newren
2022-02-22 10:05     ` Ævar Arnfjörð Bjarmason
2022-02-22 12:11     ` Johannes Schindelin
2022-02-22 13:47     ` Derrick Stolee
2022-02-23  2:26 ` [PATCH v2] repo_read_index: add config " Jonathan Nieder
2022-02-23  3:10   ` Elijah Newren
2022-02-24  5:22   ` [PATCH v3] " Elijah Newren
2022-02-24 18:24     ` Junio C Hamano
2022-02-26  5:58       ` Elijah Newren
2022-02-25 16:33     ` Jonathan Nieder
2022-02-26  6:01       ` Elijah Newren
2022-02-26  6:12     ` [PATCH v4] " Elijah Newren
2022-03-02  4:33       ` [PATCH v5] " Elijah Newren
2022-03-02  7:36         ` Junio C Hamano
2022-03-02  8:01           ` Elijah Newren
2022-03-02 13:37       ` [PATCH v4] " Derrick Stolee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f65462bf-eed7-f8b9-6255-249e5128172f@github.com \
    --to=derrickstolee@github.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=jabolopes@google.com \
    --cc=jeffhostetler@github.com \
    --cc=jonathantanmy@google.com \
    --cc=jrnieder@gmail.com \
    --cc=newren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).