From: Jakub Narebski <jnareb@gmail.com>
To: Sam Vilain <sam.vilain@catalyst.net.nz>
Cc: Frank Lichtenheld <frank@lichtenheld.de>,
git@vger.kernel.org, Petr Baudis <pasky@suse.cz>
Subject: Re: [PATCH] perl: add new module Git::Config for cached 'git config' access
Date: Tue, 07 Apr 2009 05:01:37 -0700 (PDT) [thread overview]
Message-ID: <m3prfo1xh6.fsf@localhost.localdomain> (raw)
In-Reply-To: <1239058276.31863.19.camel@maia.lan>
Sam Vilain <sam.vilain@catalyst.net.nz> writes:
> On Mon, 2009-04-06 at 11:29 +0200, Frank Lichtenheld wrote:
> > On Mon, Apr 06, 2009 at 11:46:15AM +1200, Sam Vilain wrote:
> > > + my ($fh, $c) = $git->command_output_pipe(
> > > + 'config', ( $which ? ("--$which") : () ),
> > > + '--list',
> > > + );
> >
> > Any reason why you don't use --null here? The output of --list
> > without --null is not reliably parsable, since people can put
> > newlines in values.
>
> No particularly good reason :-)
>
> Subject: [PATCH] perl: make Git::Config use --null
>
> Use the form of 'git-config' designed for parsing by modules like
> this for safety with values containing embedded line feeds.
>
> Signed-off-by: Sam Vilain <sam.vilain@catalyst.net.nz>
> diff --git a/perl/Git/Config.pm b/perl/Git/Config.pm
> index a0a6a41..a35d9f3 100644
> --- a/perl/Git/Config.pm
> +++ b/perl/Git/Config.pm
> @@ -179,12 +179,14 @@ sub read {
>
> my ($fh, $c) = $git->command_output_pipe(
> 'config', ( $which ? ("--$which") : () ),
> - '--list',
> + '--null', '--list',
> );
> my $read_state = {};
>
> + local($/)="\0";
> while (<$fh>) {
> - my ($item, $value) = m{(.*?)=(.*)};
> + my ($item, $value) = m{(.*?)\n((?s:.*))\0}
> + or die "failed to parse it; \$_='$_'";
> my $sl = \( $read_state->{$item} );
> if (!defined $$sl) {
> $$sl = $value;
Errr... wouldn't it be better to simply use
+ my ($item, $value) = split("\n", $_, 2)
here? Have you tested Git::Config with a "null" value, i.e. something
like
[section]
noval
in the config file (which evaluates to 'true' with '--bool' option)?
Because from what I remember from the discussion on the
"git config --null --list" format the lack of "\n" is used to
distinguish between noval (which is equivalent to 'true'), and empty
value (which is equivalent to 'false')
[boolean
noval # equivalent to 'true'
empty1 = # equivalent to 'false'
empty2 = "" # equivalent to 'false'
> diff --git a/t/t9700/config.t b/t/t9700/config.t
> index 395a5c9..f0f7d2d 100644
> --- a/t/t9700/config.t
> +++ b/t/t9700/config.t
> @@ -16,6 +16,7 @@ in_empty_repo sub {
> $git->command_oneline("config", "foo.intval", "12g");
> $git->command_oneline("config", "foo.false.val", "false");
> $git->command_oneline("config", "foo.true.val", "yes");
> + $git->command_oneline("config", "multiline.val", "hello\nmultiline.val=world");
>
> my $conf = Git::Config->new();
> ok($conf, "constructed a new Git::Config");
--
Jakub Narebski
Poland
ShadeHawk on #git
next prev parent reply other threads:[~2009-04-07 12:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-05 23:46 [PATCH] perl: add new module Git::Config for cached 'git config' access Sam Vilain
2009-04-05 23:46 ` [PATCH] perl: make Git.pm use new Git::Config module Sam Vilain
2009-04-06 9:29 ` [PATCH] perl: add new module Git::Config for cached 'git config' access Frank Lichtenheld
2009-04-06 22:50 ` Sam Vilain
2009-04-07 12:01 ` Jakub Narebski [this message]
2009-04-08 5:49 ` Sam Vilain
2009-04-08 10:18 ` Jakub Narebski
2009-04-08 10:44 ` Sam Vilain
2009-04-08 23:13 ` Jakub Narebski
2009-04-08 6:29 ` Junio C Hamano
2009-04-08 9:50 ` Sam Vilain
2009-04-08 18:51 ` Junio C Hamano
2009-04-08 8:12 ` Petr Baudis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3prfo1xh6.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=frank@lichtenheld.de \
--cc=git@vger.kernel.org \
--cc=pasky@suse.cz \
--cc=sam.vilain@catalyst.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).