From: Frank Lichtenheld <frank@lichtenheld.de>
To: Sam Vilain <sam.vilain@catalyst.net.nz>
Cc: git@vger.kernel.org, Petr Baudis <pasky@suse.cz>
Subject: Re: [PATCH] perl: add new module Git::Config for cached 'git config' access
Date: Mon, 6 Apr 2009 11:29:42 +0200 [thread overview]
Message-ID: <20090406092942.GW17706@mail-vs.djpig.de> (raw)
In-Reply-To: <1238975176-14354-1-git-send-email-sam.vilain@catalyst.net.nz>
On Mon, Apr 06, 2009 at 11:46:15AM +1200, Sam Vilain wrote:
> + my ($fh, $c) = $git->command_output_pipe(
> + 'config', ( $which ? ("--$which") : () ),
> + '--list',
> + );
> + my $read_state = {};
> +
> + while (<$fh>) {
> + my ($item, $value) = m{(.*?)=(.*)};
> + my $sl = \( $read_state->{$item} );
> + if (!defined $$sl) {
> + $$sl = $value;
> + }
> + elsif (!ref $$sl) {
> + $$sl = [ $$sl, $value ];
> + }
> + else {
> + push @{ $$sl }, $value;
> + }
> + }
Any reason why you don't use --null here? The output of --list without --null
is not reliably parsable, since people can put newlines in values.
Gruesse,
--
Frank Lichtenheld <frank@lichtenheld.de>
www: http://www.djpig.de/
next prev parent reply other threads:[~2009-04-06 10:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-05 23:46 [PATCH] perl: add new module Git::Config for cached 'git config' access Sam Vilain
2009-04-05 23:46 ` [PATCH] perl: make Git.pm use new Git::Config module Sam Vilain
2009-04-06 9:29 ` Frank Lichtenheld [this message]
2009-04-06 22:50 ` [PATCH] perl: add new module Git::Config for cached 'git config' access Sam Vilain
2009-04-07 12:01 ` Jakub Narebski
2009-04-08 5:49 ` Sam Vilain
2009-04-08 10:18 ` Jakub Narebski
2009-04-08 10:44 ` Sam Vilain
2009-04-08 23:13 ` Jakub Narebski
2009-04-08 6:29 ` Junio C Hamano
2009-04-08 9:50 ` Sam Vilain
2009-04-08 18:51 ` Junio C Hamano
2009-04-08 8:12 ` Petr Baudis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090406092942.GW17706@mail-vs.djpig.de \
--to=frank@lichtenheld.de \
--cc=git@vger.kernel.org \
--cc=pasky@suse.cz \
--cc=sam.vilain@catalyst.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).