From: Junio C Hamano <gitster@pobox.com>
To: Sam Vilain <samv@catalyst.net.nz>
Cc: Jakub Narebski <jnareb@gmail.com>,
Frank Lichtenheld <frank@lichtenheld.de>,
git@vger.kernel.org, Petr Baudis <pasky@suse.cz>
Subject: Re: [PATCH] perl: add new module Git::Config for cached 'git config' access
Date: Wed, 08 Apr 2009 11:51:51 -0700 [thread overview]
Message-ID: <7vtz4zm114.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 49DC736F.1030007@catalyst.net.nz
Sam Vilain <samv@catalyst.net.nz> writes:
> I'm not quite sure what you want squashed where, maybe just edit the
> below list to be how you'd like it,
>
> pick d43238e perl: add new module Git::Config for cached 'git config' access
> pick 5ea135d perl: make Git.pm use new Git::Config module
> pick b2865bc perl: make Git::Config use --null
> pick 28eecdc perl: fix no value items in Git::Config
For example, if Git::Config is a new thing that this series brings in, and
if the final decision made before the series is integrated into my tree is
that it should read from --null output, then that makes the third one an
"Oops, it was a thinko---I should have used --null from day one" fix-up
that shouldn't be in the resulting series as a separate commit, doesn't
it? I think the same applies to the last "fix no value 'true' variables"
one.
next prev parent reply other threads:[~2009-04-08 18:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-05 23:46 [PATCH] perl: add new module Git::Config for cached 'git config' access Sam Vilain
2009-04-05 23:46 ` [PATCH] perl: make Git.pm use new Git::Config module Sam Vilain
2009-04-06 9:29 ` [PATCH] perl: add new module Git::Config for cached 'git config' access Frank Lichtenheld
2009-04-06 22:50 ` Sam Vilain
2009-04-07 12:01 ` Jakub Narebski
2009-04-08 5:49 ` Sam Vilain
2009-04-08 10:18 ` Jakub Narebski
2009-04-08 10:44 ` Sam Vilain
2009-04-08 23:13 ` Jakub Narebski
2009-04-08 6:29 ` Junio C Hamano
2009-04-08 9:50 ` Sam Vilain
2009-04-08 18:51 ` Junio C Hamano [this message]
2009-04-08 8:12 ` Petr Baudis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vtz4zm114.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=frank@lichtenheld.de \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=pasky@suse.cz \
--cc=samv@catalyst.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).