From: Brandon Casey <casey@nrlssc.navy.mil>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [RFC/PATCH 1/2] Teach Solaris that _XOPEN_SOURCE=600 really menas XPG6
Date: Thu, 28 May 2009 14:40:14 -0500 [thread overview]
Message-ID: <kZP6fFCtTQSG03irLxGArpacn-5pYEauMj-b0VWwhzPWMGiC_XnsYw@cipher.nrlssc.navy.mil> (raw)
In-Reply-To: <20090528191940.GG13499@coredump.intra.peff.net>
Jeff King wrote:
> On Thu, May 28, 2009 at 11:46:50AM -0500, Brandon Casey wrote:
>
>> So we either require compiling with a c99 compiler (by ensuring that
>> _XPG6 is set) or exclude compiling with a c99 compiler on sun (by
>> ensuring that _XPG6 is not set). Actually, this would only affect Solaris
>> versions which support XPG6. Solaris 11 and 10 do. I don't know about
>> Solaris 9 and 8. Solaris 7 doesn't.
>>
>> Which do we want to do?
>
> FWIW, I didn't even try using sun's cc. I have been doing all of my
> builds using gcc 3.1.1 (from around 2002, which is what happens to be
> available on the old-ish Solaris install at my university).
It's not the compiler that prevents compilation. It's the header files.
You mentioned that on Solaris 8 there was only a single declaration for
iconv. There was not a macro check for _XPG6. I suspect that Solaris 8
does not support XPG6, so your compilation is just falling back to XPG4.
The same thing happens on Solaris 7. On Solaris 10, if the macros are
set such that _XPG6 becomes set, then compilation will fail if the
compiler is not a c99 one.
-brandon
next prev parent reply other threads:[~2009-05-28 19:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-23 19:24 [RFC/PATCH 0/2] OpenSolaris 2008.11 portability fixes Junio C Hamano
2009-05-23 19:24 ` [RFC/PATCH 1/2] Teach Solaris that _XOPEN_SOURCE=600 really menas XPG6 Junio C Hamano
2009-05-23 19:24 ` [RFC/PATCH 2/2] OpenSolaris 200811 (SunOS 5.11) does not want OLD_ICONV Junio C Hamano
2009-05-28 16:46 ` [RFC/PATCH 1/2] Teach Solaris that _XOPEN_SOURCE=600 really menas XPG6 Brandon Casey
2009-05-28 19:19 ` Jeff King
2009-05-28 19:40 ` Brandon Casey [this message]
2009-05-28 19:50 ` Jeff King
2009-05-28 20:37 ` Junio C Hamano
2009-06-11 15:06 ` Tomas Carnecky
2009-06-11 15:50 ` Brandon Casey
2009-06-11 16:42 ` Tomas Carnecky
2009-06-11 17:13 ` Brandon Casey
2009-06-11 17:36 ` Tomas Carnecky
2009-06-11 17:42 ` Brandon Casey
2009-06-11 15:58 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=kZP6fFCtTQSG03irLxGArpacn-5pYEauMj-b0VWwhzPWMGiC_XnsYw@cipher.nrlssc.navy.mil \
--to=casey@nrlssc.navy.mil \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).