From: Jeff King <peff@peff.net>
To: Brandon Casey <casey@nrlssc.navy.mil>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [RFC/PATCH 1/2] Teach Solaris that _XOPEN_SOURCE=600 really menas XPG6
Date: Thu, 28 May 2009 15:50:57 -0400 [thread overview]
Message-ID: <20090528195057.GA14360@coredump.intra.peff.net> (raw)
In-Reply-To: <kZP6fFCtTQSG03irLxGArpacn-5pYEauMj-b0VWwhzPWMGiC_XnsYw@cipher.nrlssc.navy.mil>
On Thu, May 28, 2009 at 02:40:14PM -0500, Brandon Casey wrote:
> It's not the compiler that prevents compilation. It's the header files.
>
> You mentioned that on Solaris 8 there was only a single declaration for
> iconv. There was not a macro check for _XPG6. I suspect that Solaris 8
> does not support XPG6, so your compilation is just falling back to XPG4.
OK, that makes sense.
> The same thing happens on Solaris 7. On Solaris 10, if the macros are
> set such that _XPG6 becomes set, then compilation will fail if the
> compiler is not a c99 one.
Right. What I was trying to say is "gcc 3.1.1 is probably c99 enough,
and I am using it already". That is, if you were asking how painful it
would be to require a c99 compiler for Solaris git, I am saying I don't
personally care.
But I don't know what is "normal".
-Peff
next prev parent reply other threads:[~2009-05-28 19:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-23 19:24 [RFC/PATCH 0/2] OpenSolaris 2008.11 portability fixes Junio C Hamano
2009-05-23 19:24 ` [RFC/PATCH 1/2] Teach Solaris that _XOPEN_SOURCE=600 really menas XPG6 Junio C Hamano
2009-05-23 19:24 ` [RFC/PATCH 2/2] OpenSolaris 200811 (SunOS 5.11) does not want OLD_ICONV Junio C Hamano
2009-05-28 16:46 ` [RFC/PATCH 1/2] Teach Solaris that _XOPEN_SOURCE=600 really menas XPG6 Brandon Casey
2009-05-28 19:19 ` Jeff King
2009-05-28 19:40 ` Brandon Casey
2009-05-28 19:50 ` Jeff King [this message]
2009-05-28 20:37 ` Junio C Hamano
2009-06-11 15:06 ` Tomas Carnecky
2009-06-11 15:50 ` Brandon Casey
2009-06-11 16:42 ` Tomas Carnecky
2009-06-11 17:13 ` Brandon Casey
2009-06-11 17:36 ` Tomas Carnecky
2009-06-11 17:42 ` Brandon Casey
2009-06-11 15:58 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090528195057.GA14360@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=casey@nrlssc.navy.mil \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).