git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Tomas Carnecky <tom@dbservice.com>
To: Brandon Casey <casey@nrlssc.navy.mil>
Cc: git mailing list <git@vger.kernel.org>
Subject: Re: [RFC/PATCH 1/2] Teach Solaris that _XOPEN_SOURCE=600 really menas XPG6
Date: Thu, 11 Jun 2009 19:36:15 +0200	[thread overview]
Message-ID: <4F909897-DD86-4C35-B18F-BE1CFBF06FAE@dbservice.com> (raw)
In-Reply-To: <UBftUjN2Jk2tj73et7i3WvuSUhtOiNjPVjmux6IKeXOo0Zs8KHgrOA@cipher.nrlssc.navy.mil>


On Jun 11, 2009, at 7:13 PM, Brandon Casey wrote:
> Ok, great.  Looks like Sun fixed the flaw that was present in the 5.8
> compiler, and no other changes need to be made to git.  To be  
> absolutely
> sure, and if you have a moment, can you try to compile the code  
> snippet at
> the end of this email?
>
> If you name the saved the code "test.c", then just compile with
>
>   /opt/SUNWspro/bin/c99 -c test.c
>
> The Sun C 5.8 compiler complains like this for me:
>
>   "test.c", line 12: identifier redeclared: test_func
>           current : function(pointer to const struct a_struct {int  
> b, array[-1] of pointer to char c}) returning pointer to void
>           previous: function(pointer to const struct a_struct {int  
> b, array[-1] of pointer to char c}) returning pointer to void :  
> "test.c", line 4
>   c99: acomp failed for test.c
>
> If the 5.9 compiler successfully compiles it, then this new version  
> of Sun's
> compiler correctly handles c99 flex arrays.

It compiles without errors.

tom

  reply	other threads:[~2009-06-11 17:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-23 19:24 [RFC/PATCH 0/2] OpenSolaris 2008.11 portability fixes Junio C Hamano
2009-05-23 19:24 ` [RFC/PATCH 1/2] Teach Solaris that _XOPEN_SOURCE=600 really menas XPG6 Junio C Hamano
2009-05-23 19:24   ` [RFC/PATCH 2/2] OpenSolaris 200811 (SunOS 5.11) does not want OLD_ICONV Junio C Hamano
2009-05-28 16:46   ` [RFC/PATCH 1/2] Teach Solaris that _XOPEN_SOURCE=600 really menas XPG6 Brandon Casey
2009-05-28 19:19     ` Jeff King
2009-05-28 19:40       ` Brandon Casey
2009-05-28 19:50         ` Jeff King
2009-05-28 20:37     ` Junio C Hamano
2009-06-11 15:06   ` Tomas Carnecky
2009-06-11 15:50     ` Brandon Casey
2009-06-11 16:42       ` Tomas Carnecky
2009-06-11 17:13         ` Brandon Casey
2009-06-11 17:36           ` Tomas Carnecky [this message]
2009-06-11 17:42             ` Brandon Casey
2009-06-11 15:58     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F909897-DD86-4C35-B18F-BE1CFBF06FAE@dbservice.com \
    --to=tom@dbservice.com \
    --cc=casey@nrlssc.navy.mil \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).