* [PATCH] fetch-object.h: add missing declaration (hdr-check)
@ 2018-09-19 0:18 Ramsay Jones
2018-09-21 16:21 ` Junio C Hamano
0 siblings, 1 reply; 5+ messages in thread
From: Ramsay Jones @ 2018-09-19 0:18 UTC (permalink / raw)
To: Junio C Hamano; +Cc: GIT Mailing-list
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Junio,
This is the patch I needed for the current 'next' branch to get
a clean 'hdr-check'
ATB,
Ramsay Jones
fetch-object.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fetch-object.h b/fetch-object.h
index d2f996d4e8..d6444caa5a 100644
--- a/fetch-object.h
+++ b/fetch-object.h
@@ -1,6 +1,8 @@
#ifndef FETCH_OBJECT_H
#define FETCH_OBJECT_H
+struct object_id;
+
void fetch_objects(const char *remote_name, const struct object_id *oids,
int oid_nr);
--
2.19.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] fetch-object.h: add missing declaration (hdr-check)
2018-09-19 0:18 [PATCH] fetch-object.h: add missing declaration (hdr-check) Ramsay Jones
@ 2018-09-21 16:21 ` Junio C Hamano
2018-09-21 16:47 ` Ramsay Jones
0 siblings, 1 reply; 5+ messages in thread
From: Junio C Hamano @ 2018-09-21 16:21 UTC (permalink / raw)
To: Ramsay Jones; +Cc: GIT Mailing-list
Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Junio,
>
> This is the patch I needed for the current 'next' branch to get
> a clean 'hdr-check'
Which means that this is a fix on top of jt/lazy-object-fetch-fix
topic, I think.
Will apply there.
Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fetch-object.h: add missing declaration (hdr-check)
2018-09-21 16:21 ` Junio C Hamano
@ 2018-09-21 16:47 ` Ramsay Jones
2018-09-21 17:05 ` Junio C Hamano
0 siblings, 1 reply; 5+ messages in thread
From: Ramsay Jones @ 2018-09-21 16:47 UTC (permalink / raw)
To: Junio C Hamano; +Cc: GIT Mailing-list
On 21/09/18 17:21, Junio C Hamano wrote:
> Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
>
>> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
>> ---
>>
>> Hi Junio,
>>
>> This is the patch I needed for the current 'next' branch to get
>> a clean 'hdr-check'
>
> Which means that this is a fix on top of jt/lazy-object-fetch-fix
> topic, I think.
>
> Will apply there.
Yes, indeed. Sorry, I should have added that information, rather
than forcing you to look it up! (Similar comment on the userdiff.h
patch as well) :(
BTW, I notice that patch #9 (commit-reach.h: add missing declarations
(hdr-check)) didn't make it onto 'pu' - was there something else I
needed to do? (I am still in two minds about sending an RFC patch
on-top of patch #9).
Thanks!
ATB,
Ramsay Jones
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fetch-object.h: add missing declaration (hdr-check)
2018-09-21 16:47 ` Ramsay Jones
@ 2018-09-21 17:05 ` Junio C Hamano
2018-09-21 17:40 ` Derrick Stolee
0 siblings, 1 reply; 5+ messages in thread
From: Junio C Hamano @ 2018-09-21 17:05 UTC (permalink / raw)
To: Ramsay Jones; +Cc: GIT Mailing-list
Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
> BTW, I notice that patch #9 (commit-reach.h: add missing declarations
> (hdr-check)) didn't make it onto 'pu' - was there something else I
> needed to do? (I am still in two minds about sending an RFC patch
> on-top of patch #9).
I refrained from queuing it as I did not sense a clear resolution of
the discussion.
I found it a sign that you may want to update the log message to
explain "instead of adding a few forward decls, include the whole
commit.h because..." that you had to explain why the patch did what
it did to Derrick in a follow-up message.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fetch-object.h: add missing declaration (hdr-check)
2018-09-21 17:05 ` Junio C Hamano
@ 2018-09-21 17:40 ` Derrick Stolee
0 siblings, 0 replies; 5+ messages in thread
From: Derrick Stolee @ 2018-09-21 17:40 UTC (permalink / raw)
To: Junio C Hamano, Ramsay Jones; +Cc: GIT Mailing-list
On 9/21/2018 1:05 PM, Junio C Hamano wrote:
> Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
>
>> BTW, I notice that patch #9 (commit-reach.h: add missing declarations
>> (hdr-check)) didn't make it onto 'pu' - was there something else I
>> needed to do? (I am still in two minds about sending an RFC patch
>> on-top of patch #9).
> I refrained from queuing it as I did not sense a clear resolution of
> the discussion.
>
> I found it a sign that you may want to update the log message to
> explain "instead of adding a few forward decls, include the whole
> commit.h because..." that you had to explain why the patch did what
> it did to Derrick in a follow-up message.
Also my fault for not saying "That's a good reason, thanks for
explaining!" (I'll add that to the necessary thread.)
-Stolee
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-09-21 17:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-19 0:18 [PATCH] fetch-object.h: add missing declaration (hdr-check) Ramsay Jones
2018-09-21 16:21 ` Junio C Hamano
2018-09-21 16:47 ` Ramsay Jones
2018-09-21 17:05 ` Junio C Hamano
2018-09-21 17:40 ` Derrick Stolee
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).