git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] fetch-object.h: add missing declaration (hdr-check)
Date: Fri, 21 Sep 2018 10:05:22 -0700	[thread overview]
Message-ID: <xmqq7ejewzl9.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <f6663e27-cfe6-c927-746c-dfbeed5bb3a2@ramsayjones.plus.com> (Ramsay Jones's message of "Fri, 21 Sep 2018 17:47:03 +0100")

Ramsay Jones <ramsay@ramsayjones.plus.com> writes:

> BTW, I notice that patch #9 (commit-reach.h: add missing declarations
>  (hdr-check)) didn't make it onto 'pu' - was there something else I
> needed to do? (I am still in two minds about sending an RFC patch
> on-top of patch #9).

I refrained from queuing it as I did not sense a clear resolution of
the discussion.

I found it a sign that you may want to update the log message to
explain "instead of adding a few forward decls, include the whole
commit.h because..." that you had to explain why the patch did what
it did to Derrick in a follow-up message.

  reply	other threads:[~2018-09-21 17:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-19  0:18 [PATCH] fetch-object.h: add missing declaration (hdr-check) Ramsay Jones
2018-09-21 16:21 ` Junio C Hamano
2018-09-21 16:47   ` Ramsay Jones
2018-09-21 17:05     ` Junio C Hamano [this message]
2018-09-21 17:40       ` Derrick Stolee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7ejewzl9.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=ramsay@ramsayjones.plus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).