From: Stephen Finucane <stephen@that.guru>
To: "Michal Suchánek" <msuchanek@suse.de>,
"Konstantin Ryabitsev" <konstantin@linuxfoundation.org>
Cc: git@vger.kernel.org
Subject: Re: Feature request: provide a persistent IDs on a commit
Date: Tue, 19 Jul 2022 11:57:39 +0100 [thread overview]
Message-ID: <e2d73c87ae798de6d1dd21fe14371b8cdc65228f.camel@that.guru> (raw)
In-Reply-To: <20220718190403.GT17705@kitsune.suse.cz>
On Mon, 2022-07-18 at 21:04 +0200, Michal Suchánek wrote:
> On Mon, Jul 18, 2022 at 01:35:11PM -0400, Konstantin Ryabitsev wrote:
> > On Mon, Jul 18, 2022 at 06:18:11PM +0100, Stephen Finucane wrote:
> > > ...to track evolution of a patch through time.
> > >
> > > tl;dr: How hard would it be to retrofit an 'ChangeID' concept à la the 'Change-
> > > ID' trailer used by Gerrit into git core?
> >
> > I just started working on this for b4, with the notable difference that the
> > change-id trailer is used in the cover letter instead of in individual
> > commits, which moves the concept of "change" from a single commit to a series
> > of commits. IMO, it's much more useful in that scope, because as series are
> > reviewed and iterated, individual patches can get squashed, split up or
> > otherwise transformed.
>
> You can turn that around and say that IDs of individual commits are more
> powerful because they are preserved as series are reviewed, split,
> merged, and commits cherry-picked.
There's also the fact that many communities insist on small, atomic commits:
they're much easier to review. It stands to reason that reviewing a series on a
patch-by-patch basis is also much easier, as is reviewing a series _revision_ on
a patch-by-patch basis. To be able to do this though, you need to be able to map
patch revisions to their predecessors/successors and well as the series
revisions. I don't see how you realistically rely on a series-only identifier.
There's no reason 'git-format-patch' couldn't allow you to set an
AuthorID/ChangeID/<whatever we want to call this field> value for a cover
letter, though it obviously would need to be done manually since cover letters
aren't git objects.
git send-email \
--reroll-count 2 \
--series-id 300628e5-8b27-45fe-be71-95417f7ccd6f
main
Stephen
>
> Thanks
>
> Michal
next prev parent reply other threads:[~2022-07-19 10:58 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 17:18 Feature request: provide a persistent IDs on a commit Stephen Finucane
2022-07-18 17:35 ` Konstantin Ryabitsev
2022-07-18 19:04 ` Michal Suchánek
2022-07-19 10:57 ` Stephen Finucane [this message]
2022-07-18 21:24 ` Glen Choo
2022-07-20 19:21 ` Konstantin Ryabitsev
2022-07-20 19:30 ` Michal Suchánek
2022-07-20 22:10 ` Theodore Ts'o
2022-07-21 11:57 ` Han-Wen Nienhuys
2022-07-24 5:09 ` Elijah Newren
2022-07-18 18:50 ` Ævar Arnfjörð Bjarmason
2022-07-19 10:47 ` Stephen Finucane
2022-07-19 11:09 ` Ævar Arnfjörð Bjarmason
2022-07-19 11:57 ` Michal Suchánek
2022-07-29 12:11 ` Stephen Finucane
2022-07-29 12:40 ` Jason Pyeron
2022-07-21 16:18 ` Phillip Susi
2022-07-21 18:58 ` Hilco Wijbenga
2022-07-22 20:08 ` Philip Oakley
2022-07-22 20:36 ` Michal Suchánek
2022-07-22 22:46 ` Jacob Keller
2022-07-23 7:00 ` Michal Suchánek
2022-07-24 5:23 ` Elijah Newren
2022-07-24 8:54 ` Michal Suchánek
2022-07-25 21:47 ` Jacob Keller
2022-07-26 3:49 ` Elijah Newren
2022-07-26 8:43 ` Michal Suchánek
2022-07-24 5:10 ` Elijah Newren
2022-07-24 8:59 ` Michal Suchánek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2d73c87ae798de6d1dd21fe14371b8cdc65228f.camel@that.guru \
--to=stephen@that.guru \
--cc=git@vger.kernel.org \
--cc=konstantin@linuxfoundation.org \
--cc=msuchanek@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).