git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Michal Suchánek" <msuchanek@suse.de>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: Glen Choo <chooglen@google.com>,
	Stephen Finucane <stephen@that.guru>,
	git@vger.kernel.org
Subject: Re: Feature request: provide a persistent IDs on a commit
Date: Wed, 20 Jul 2022 21:30:10 +0200	[thread overview]
Message-ID: <20220720193010.GZ17705@kitsune.suse.cz> (raw)
In-Reply-To: <20220720192144.mxdemgcdjxb2klgl@nitro.local>

On Wed, Jul 20, 2022 at 03:21:44PM -0400, Konstantin Ryabitsev wrote:
> On Mon, Jul 18, 2022 at 02:24:07PM -0700, Glen Choo wrote:
> > > I just started working on this for b4, with the notable difference that the
> > > change-id trailer is used in the cover letter instead of in individual
> > > commits, which moves the concept of "change" from a single commit to a series
> > > of commits. IMO, it's much more useful in that scope, because as series are
> > > reviewed and iterated, individual patches can get squashed, split up or
> > > otherwise transformed.
> > 
> > My 2 cents, since I used to use Gerrit a lot :)
> > 
> > I find persistent per-commit ids really useful, even when patches get
> > moved around. E.g. Gerrit can show and diff previous versions of the
> > patch, which makes it really easy to tell how the patch has evolved
> > over time.
> 
> The kernel community has repeatedly rejected per-patch Change-id trailers
> because they carry no meaningful information outside of the gerrit system on
> which they were created. Seeing a Change-Id trailer in a commit tells you
> nothing about the history of that commit unless you know the gerrit system on

Unless you happen to see another patch with the same ID, and for that to
happen the ID needs to be generated when the commit is created (not when
it's uploaded to gerrit or sent to a mailing list), and preserved by
default in all processing of the commit.

Then you can actually track the commit as it evolves in tools like
patchwork, in theory.

Thanks

Michal

  reply	other threads:[~2022-07-20 19:30 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-18 17:18 Feature request: provide a persistent IDs on a commit Stephen Finucane
2022-07-18 17:35 ` Konstantin Ryabitsev
2022-07-18 19:04   ` Michal Suchánek
2022-07-19 10:57     ` Stephen Finucane
2022-07-18 21:24   ` Glen Choo
2022-07-20 19:21     ` Konstantin Ryabitsev
2022-07-20 19:30       ` Michal Suchánek [this message]
2022-07-20 22:10       ` Theodore Ts'o
2022-07-21 11:57         ` Han-Wen Nienhuys
2022-07-24  5:09     ` Elijah Newren
2022-07-18 18:50 ` Ævar Arnfjörð Bjarmason
2022-07-19 10:47   ` Stephen Finucane
2022-07-19 11:09     ` Ævar Arnfjörð Bjarmason
2022-07-19 11:57       ` Michal Suchánek
2022-07-29 12:11       ` Stephen Finucane
2022-07-29 12:40         ` Jason Pyeron
2022-07-21 16:18   ` Phillip Susi
2022-07-21 18:58     ` Hilco Wijbenga
2022-07-22 20:08       ` Philip Oakley
2022-07-22 20:36         ` Michal Suchánek
2022-07-22 22:46           ` Jacob Keller
2022-07-23  7:00             ` Michal Suchánek
2022-07-24  5:23               ` Elijah Newren
2022-07-24  8:54                 ` Michal Suchánek
2022-07-25 21:47                 ` Jacob Keller
2022-07-26  3:49                   ` Elijah Newren
2022-07-26  8:43                     ` Michal Suchánek
2022-07-24  5:10           ` Elijah Newren
2022-07-24  8:59             ` Michal Suchánek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220720193010.GZ17705@kitsune.suse.cz \
    --to=msuchanek@suse.de \
    --cc=chooglen@google.com \
    --cc=git@vger.kernel.org \
    --cc=konstantin@linuxfoundation.org \
    --cc=stephen@that.guru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).