From: Han-Wen Nienhuys <hanwen@google.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
Glen Choo <chooglen@google.com>,
Stephen Finucane <stephen@that.guru>,
git@vger.kernel.org
Subject: Re: Feature request: provide a persistent IDs on a commit
Date: Thu, 21 Jul 2022 13:57:56 +0200 [thread overview]
Message-ID: <CAFQ2z_Mc6Z-FyFkUURMCM11yQTH+Y2PLBrAKB-16BXv159=oOA@mail.gmail.com> (raw)
In-Reply-To: <Yth9TCCEXfmagaaw@mit.edu>
On Thu, Jul 21, 2022 at 12:10 AM Theodore Ts'o <tytso@mit.edu> wrote:
> On Wed, Jul 20, 2022 at 03:21:44PM -0400, Konstantin Ryabitsev wrote:
> > The kernel community has repeatedly rejected per-patch Change-id trailers
> > because they carry no meaningful information outside of the gerrit system on
> > which they were created. Seeing a Change-Id trailer in a commit tells you
> > nothing about the history of that commit unless you know the gerrit system on
> > which this patch was reviewed (and have access to it, which is not a given).
>
> The "no meaningful information outside of the gerrit system" is the
> key. This was extensively discussed in the
> ksummit-discuss@lists.linux-foundation.org mailing list in late August
> 2019, subject line "Allowing something Change-Id (or something like
> it) in kernel commits". Quoting from Linus Torvalds:
>
> From: Linus Torvalds
> Date: Thu, 22 Aug 2019 17:17:05 -0700
> Message-Id: CAHk-=whFbgy4RXG11c_=S7O-248oWmwB_aZOcWzWMVh3w7=RCw@mail.gmail.com
>
> No. That's not it at all. It's not "dislike gerrit".
>
> It's "dislike pointless garbage".
>
> If the gerrit database is public and searchable using the uuid, then
> that would make the uuid useful to outsiders. And instead of just
> putting a UUID (which is hard to look up unless you know where it came
> from), make it be that "Link:" that gives not just the UUID, but also
> gives you the metadata for that UUID to be looked up.
>..
> So if you guys make the gerrit database actually public, and then
> start adding "Link: ..." tags so that we can see what they point to, I
> think people will be more than supportive of it.
Support for the "Link:" footer as a change ID has been implemented in
Gerrit as of https://gerrit.googlesource.com/gerrit/+/8cab93302d9c35316d691e848b67e687a68182b5
(available in Gerrit 3.3 and onwards). I'm not sure if it has seen
much use, though.
--
Han-Wen Nienhuys - Google Munich
I work 80%. Don't expect answers from me on Fridays.
--
Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Paul Manicle, Liana Sebastian
next prev parent reply other threads:[~2022-07-21 11:58 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-18 17:18 Feature request: provide a persistent IDs on a commit Stephen Finucane
2022-07-18 17:35 ` Konstantin Ryabitsev
2022-07-18 19:04 ` Michal Suchánek
2022-07-19 10:57 ` Stephen Finucane
2022-07-18 21:24 ` Glen Choo
2022-07-20 19:21 ` Konstantin Ryabitsev
2022-07-20 19:30 ` Michal Suchánek
2022-07-20 22:10 ` Theodore Ts'o
2022-07-21 11:57 ` Han-Wen Nienhuys [this message]
2022-07-24 5:09 ` Elijah Newren
2022-07-18 18:50 ` Ævar Arnfjörð Bjarmason
2022-07-19 10:47 ` Stephen Finucane
2022-07-19 11:09 ` Ævar Arnfjörð Bjarmason
2022-07-19 11:57 ` Michal Suchánek
2022-07-29 12:11 ` Stephen Finucane
2022-07-29 12:40 ` Jason Pyeron
2022-07-21 16:18 ` Phillip Susi
2022-07-21 18:58 ` Hilco Wijbenga
2022-07-22 20:08 ` Philip Oakley
2022-07-22 20:36 ` Michal Suchánek
2022-07-22 22:46 ` Jacob Keller
2022-07-23 7:00 ` Michal Suchánek
2022-07-24 5:23 ` Elijah Newren
2022-07-24 8:54 ` Michal Suchánek
2022-07-25 21:47 ` Jacob Keller
2022-07-26 3:49 ` Elijah Newren
2022-07-26 8:43 ` Michal Suchánek
2022-07-24 5:10 ` Elijah Newren
2022-07-24 8:59 ` Michal Suchánek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFQ2z_Mc6Z-FyFkUURMCM11yQTH+Y2PLBrAKB-16BXv159=oOA@mail.gmail.com' \
--to=hanwen@google.com \
--cc=chooglen@google.com \
--cc=git@vger.kernel.org \
--cc=konstantin@linuxfoundation.org \
--cc=stephen@that.guru \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).